Skip to content

Commit 429a98a

Browse files
Dan Carpentergregkh
authored andcommitted
usb: typec: class: Unlocked on error in typec_register_partner()
We recently added some locking to this function but this error path was accidentally missed. Unlock before returning. Fixes: ec27386 ("usb: typec: class: Fix NULL pointer access") Cc: stable <stable@kernel.org> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org> Reviewed-by: Heikki Krogerus <heikki.krogerus@linux.intel.com> Link: https://lore.kernel.org/r/Z_44tOtmml89wQcM@stanley.mountain Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
1 parent 37ffdbd commit 429a98a

File tree

1 file changed

+1
-0
lines changed

1 file changed

+1
-0
lines changed

drivers/usb/typec/class.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1056,6 +1056,7 @@ struct typec_partner *typec_register_partner(struct typec_port *port,
10561056
ret = device_register(&partner->dev);
10571057
if (ret) {
10581058
dev_err(&port->dev, "failed to register partner (%d)\n", ret);
1059+
mutex_unlock(&port->partner_link_lock);
10591060
put_device(&partner->dev);
10601061
return ERR_PTR(ret);
10611062
}

0 commit comments

Comments
 (0)