Skip to content

Commit 3998614

Browse files
Jeff Johnsonrichardweinberger
authored andcommitted
ubifs: fix kernel-doc warnings
make C=1 reports the following kernel-doc warnings: fs/ubifs/compress.c:103: warning: Function parameter or struct member 'c' not described in 'ubifs_compress' fs/ubifs/compress.c:155: warning: Function parameter or struct member 'c' not described in 'ubifs_decompress' fs/ubifs/find.c:353: warning: Excess function parameter 'data' description in 'scan_for_free_cb' fs/ubifs/find.c:353: warning: Function parameter or struct member 'arg' not described in 'scan_for_free_cb' fs/ubifs/find.c:594: warning: Excess function parameter 'data' description in 'scan_for_idx_cb' fs/ubifs/find.c:594: warning: Function parameter or struct member 'arg' not described in 'scan_for_idx_cb' fs/ubifs/find.c:786: warning: Excess function parameter 'data' description in 'scan_dirty_idx_cb' fs/ubifs/find.c:786: warning: Function parameter or struct member 'arg' not described in 'scan_dirty_idx_cb' fs/ubifs/find.c:86: warning: Excess function parameter 'data' description in 'scan_for_dirty_cb' fs/ubifs/find.c:86: warning: Function parameter or struct member 'arg' not described in 'scan_for_dirty_cb' fs/ubifs/journal.c:369: warning: expecting prototype for wake_up_reservation(). Prototype was for add_or_start_queue() instead fs/ubifs/lprops.c:1018: warning: Excess function parameter 'lst' description in 'scan_check_cb' fs/ubifs/lprops.c:1018: warning: Function parameter or struct member 'arg' not described in 'scan_check_cb' fs/ubifs/lpt.c:1938: warning: Function parameter or struct member 'ptr' not described in 'lpt_scan_node' fs/ubifs/replay.c:60: warning: Function parameter or struct member 'hash' not described in 'replay_entry' Fix them. Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> Reviewed-by: Zhihao Cheng <chengzhihao1@huawei.com> Signed-off-by: Richard Weinberger <richard@nod.at>
1 parent 7037c96 commit 3998614

File tree

6 files changed

+10
-6
lines changed

6 files changed

+10
-6
lines changed

fs/ubifs/compress.c

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -82,6 +82,7 @@ struct ubifs_compressor *ubifs_compressors[UBIFS_COMPR_TYPES_CNT];
8282

8383
/**
8484
* ubifs_compress - compress data.
85+
* @c: UBIFS file-system description object
8586
* @in_buf: data to compress
8687
* @in_len: length of the data to compress
8788
* @out_buf: output buffer where compressed data should be stored
@@ -140,6 +141,7 @@ void ubifs_compress(const struct ubifs_info *c, const void *in_buf,
140141

141142
/**
142143
* ubifs_decompress - decompress data.
144+
* @c: UBIFS file-system description object
143145
* @in_buf: data to decompress
144146
* @in_len: length of the data to decompress
145147
* @out_buf: output buffer where decompressed data should

fs/ubifs/find.c

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -73,7 +73,7 @@ static int valuable(struct ubifs_info *c, const struct ubifs_lprops *lprops)
7373
* @c: the UBIFS file-system description object
7474
* @lprops: LEB properties to scan
7575
* @in_tree: whether the LEB properties are in main memory
76-
* @data: information passed to and from the caller of the scan
76+
* @arg: information passed to and from the caller of the scan
7777
*
7878
* This function returns a code that indicates whether the scan should continue
7979
* (%LPT_SCAN_CONTINUE), whether the LEB properties should be added to the tree
@@ -340,7 +340,7 @@ int ubifs_find_dirty_leb(struct ubifs_info *c, struct ubifs_lprops *ret_lp,
340340
* @c: the UBIFS file-system description object
341341
* @lprops: LEB properties to scan
342342
* @in_tree: whether the LEB properties are in main memory
343-
* @data: information passed to and from the caller of the scan
343+
* @arg: information passed to and from the caller of the scan
344344
*
345345
* This function returns a code that indicates whether the scan should continue
346346
* (%LPT_SCAN_CONTINUE), whether the LEB properties should be added to the tree
@@ -581,7 +581,7 @@ int ubifs_find_free_space(struct ubifs_info *c, int min_space, int *offs,
581581
* @c: the UBIFS file-system description object
582582
* @lprops: LEB properties to scan
583583
* @in_tree: whether the LEB properties are in main memory
584-
* @data: information passed to and from the caller of the scan
584+
* @arg: information passed to and from the caller of the scan
585585
*
586586
* This function returns a code that indicates whether the scan should continue
587587
* (%LPT_SCAN_CONTINUE), whether the LEB properties should be added to the tree
@@ -773,7 +773,7 @@ int ubifs_save_dirty_idx_lnums(struct ubifs_info *c)
773773
* @c: the UBIFS file-system description object
774774
* @lprops: LEB properties to scan
775775
* @in_tree: whether the LEB properties are in main memory
776-
* @data: information passed to and from the caller of the scan
776+
* @arg: information passed to and from the caller of the scan
777777
*
778778
* This function returns a code that indicates whether the scan should continue
779779
* (%LPT_SCAN_CONTINUE), whether the LEB properties should be added to the tree

fs/ubifs/journal.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -359,7 +359,7 @@ static void wake_up_reservation(struct ubifs_info *c)
359359
}
360360

361361
/**
362-
* wake_up_reservation - add current task in queue or start queuing.
362+
* add_or_start_queue - add current task in queue or start queuing.
363363
* @c: UBIFS file-system description object
364364
*
365365
* This function starts queuing if queuing is not started, otherwise adds

fs/ubifs/lprops.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1005,7 +1005,7 @@ void dbg_check_heap(struct ubifs_info *c, struct ubifs_lpt_heap *heap, int cat,
10051005
* @c: the UBIFS file-system description object
10061006
* @lp: LEB properties to scan
10071007
* @in_tree: whether the LEB properties are in main memory
1008-
* @lst: lprops statistics to update
1008+
* @arg: lprops statistics to update
10091009
*
10101010
* This function returns a code that indicates whether the scan should continue
10111011
* (%LPT_SCAN_CONTINUE), whether the LEB properties should be added to the tree

fs/ubifs/lpt.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1918,6 +1918,7 @@ int ubifs_lpt_init(struct ubifs_info *c, int rd, int wr)
19181918
* @pnode: where to keep a pnode
19191919
* @cnode: where to keep a cnode
19201920
* @in_tree: is the node in the tree in memory
1921+
* @ptr: union of node pointers
19211922
* @ptr.nnode: pointer to the nnode (if it is an nnode) which may be here or in
19221923
* the tree
19231924
* @ptr.pnode: ditto for pnode

fs/ubifs/replay.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -29,6 +29,7 @@
2929
* @lnum: logical eraseblock number of the node
3030
* @offs: node offset
3131
* @len: node length
32+
* @hash: node hash
3233
* @deletion: non-zero if this entry corresponds to a node deletion
3334
* @sqnum: node sequence number
3435
* @list: links the replay list

0 commit comments

Comments
 (0)