Skip to content

Commit 367ed4e

Browse files
Ingo MolnarKAGA-KOKO
authored andcommitted
treewide, timers: Rename try_to_del_timer_sync() as timer_delete_sync_try()
Move this API to the canonical timer_*() namespace. Signed-off-by: Ingo Molnar <mingo@kernel.org> Signed-off-by: Thomas Gleixner <tglx@linutronix.de> Link: https://lore.kernel.org/all/20250507175338.672442-9-mingo@kernel.org
1 parent 751e6a3 commit 367ed4e

File tree

7 files changed

+17
-17
lines changed

7 files changed

+17
-17
lines changed

arch/x86/kernel/apic/vector.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -864,7 +864,7 @@ void lapic_offline(void)
864864
__vector_cleanup(cl, false);
865865

866866
irq_matrix_offline(vector_matrix);
867-
WARN_ON_ONCE(try_to_del_timer_sync(&cl->timer) < 0);
867+
WARN_ON_ONCE(timer_delete_sync_try(&cl->timer) < 0);
868868
WARN_ON_ONCE(!hlist_empty(&cl->head));
869869

870870
unlock_vector_lock();

drivers/char/random.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1311,9 +1311,9 @@ static void __cold try_to_generate_entropy(void)
13111311
while (!crng_ready() && !signal_pending(current)) {
13121312
/*
13131313
* Check !timer_pending() and then ensure that any previous callback has finished
1314-
* executing by checking try_to_del_timer_sync(), before queueing the next one.
1314+
* executing by checking timer_delete_sync_try(), before queueing the next one.
13151315
*/
1316-
if (!timer_pending(&stack->timer) && try_to_del_timer_sync(&stack->timer) >= 0) {
1316+
if (!timer_pending(&stack->timer) && timer_delete_sync_try(&stack->timer) >= 0) {
13171317
struct cpumask timer_cpus;
13181318
unsigned int num_cpus;
13191319

drivers/irqchip/irq-riscv-imsic-state.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -564,7 +564,7 @@ void imsic_state_offline(void)
564564
struct imsic_local_priv *lpriv = this_cpu_ptr(imsic->lpriv);
565565

566566
raw_spin_lock_irqsave(&lpriv->lock, flags);
567-
WARN_ON_ONCE(try_to_del_timer_sync(&lpriv->timer) < 0);
567+
WARN_ON_ONCE(timer_delete_sync_try(&lpriv->timer) < 0);
568568
raw_spin_unlock_irqrestore(&lpriv->lock, flags);
569569
#endif
570570
}

include/linux/timer.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ extern void add_timer(struct timer_list *timer);
162162
extern void add_timer_local(struct timer_list *timer);
163163
extern void add_timer_global(struct timer_list *timer);
164164

165-
extern int try_to_del_timer_sync(struct timer_list *timer);
165+
extern int timer_delete_sync_try(struct timer_list *timer);
166166
extern int timer_delete_sync(struct timer_list *timer);
167167
extern int timer_delete(struct timer_list *timer);
168168
extern int timer_shutdown_sync(struct timer_list *timer);

kernel/time/timer.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1511,7 +1511,7 @@ static int __try_to_del_timer_sync(struct timer_list *timer, bool shutdown)
15111511
}
15121512

15131513
/**
1514-
* try_to_del_timer_sync - Try to deactivate a timer
1514+
* timer_delete_sync_try - Try to deactivate a timer
15151515
* @timer: Timer to deactivate
15161516
*
15171517
* This function tries to deactivate a timer. On success the timer is not
@@ -1526,11 +1526,11 @@ static int __try_to_del_timer_sync(struct timer_list *timer, bool shutdown)
15261526
* * %1 - The timer was pending and deactivated
15271527
* * %-1 - The timer callback function is running on a different CPU
15281528
*/
1529-
int try_to_del_timer_sync(struct timer_list *timer)
1529+
int timer_delete_sync_try(struct timer_list *timer)
15301530
{
15311531
return __try_to_del_timer_sync(timer, false);
15321532
}
1533-
EXPORT_SYMBOL(try_to_del_timer_sync);
1533+
EXPORT_SYMBOL(timer_delete_sync_try);
15341534

15351535
#ifdef CONFIG_PREEMPT_RT
15361536
static __init void timer_base_init_expiry_lock(struct timer_base *base)

net/bridge/br_multicast.c

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -2061,7 +2061,7 @@ static void br_multicast_enable(struct bridge_mcast_own_query *query)
20612061
{
20622062
query->startup_sent = 0;
20632063

2064-
if (try_to_del_timer_sync(&query->timer) >= 0 ||
2064+
if (timer_delete_sync_try(&query->timer) >= 0 ||
20652065
timer_delete(&query->timer))
20662066
mod_timer(&query->timer, jiffies);
20672067
}
@@ -3480,15 +3480,15 @@ static void br_ip4_multicast_query(struct net_bridge_mcast *brmctx,
34803480
if (mp->host_joined &&
34813481
(timer_pending(&mp->timer) ?
34823482
time_after(mp->timer.expires, now + max_delay) :
3483-
try_to_del_timer_sync(&mp->timer) >= 0))
3483+
timer_delete_sync_try(&mp->timer) >= 0))
34843484
mod_timer(&mp->timer, now + max_delay);
34853485

34863486
for (pp = &mp->ports;
34873487
(p = mlock_dereference(*pp, brmctx->br)) != NULL;
34883488
pp = &p->next) {
34893489
if (timer_pending(&p->timer) ?
34903490
time_after(p->timer.expires, now + max_delay) :
3491-
try_to_del_timer_sync(&p->timer) >= 0 &&
3491+
timer_delete_sync_try(&p->timer) >= 0 &&
34923492
(brmctx->multicast_igmp_version == 2 ||
34933493
p->filter_mode == MCAST_EXCLUDE))
34943494
mod_timer(&p->timer, now + max_delay);
@@ -3569,15 +3569,15 @@ static int br_ip6_multicast_query(struct net_bridge_mcast *brmctx,
35693569
if (mp->host_joined &&
35703570
(timer_pending(&mp->timer) ?
35713571
time_after(mp->timer.expires, now + max_delay) :
3572-
try_to_del_timer_sync(&mp->timer) >= 0))
3572+
timer_delete_sync_try(&mp->timer) >= 0))
35733573
mod_timer(&mp->timer, now + max_delay);
35743574

35753575
for (pp = &mp->ports;
35763576
(p = mlock_dereference(*pp, brmctx->br)) != NULL;
35773577
pp = &p->next) {
35783578
if (timer_pending(&p->timer) ?
35793579
time_after(p->timer.expires, now + max_delay) :
3580-
try_to_del_timer_sync(&p->timer) >= 0 &&
3580+
timer_delete_sync_try(&p->timer) >= 0 &&
35813581
(brmctx->multicast_mld_version == 1 ||
35823582
p->filter_mode == MCAST_EXCLUDE))
35833583
mod_timer(&p->timer, now + max_delay);
@@ -3649,7 +3649,7 @@ br_multicast_leave_group(struct net_bridge_mcast *brmctx,
36493649
if (!hlist_unhashed(&p->mglist) &&
36503650
(timer_pending(&p->timer) ?
36513651
time_after(p->timer.expires, time) :
3652-
try_to_del_timer_sync(&p->timer) >= 0)) {
3652+
timer_delete_sync_try(&p->timer) >= 0)) {
36533653
mod_timer(&p->timer, time);
36543654
}
36553655

@@ -3665,7 +3665,7 @@ br_multicast_leave_group(struct net_bridge_mcast *brmctx,
36653665
if (mp->host_joined &&
36663666
(timer_pending(&mp->timer) ?
36673667
time_after(mp->timer.expires, time) :
3668-
try_to_del_timer_sync(&mp->timer) >= 0)) {
3668+
timer_delete_sync_try(&mp->timer) >= 0)) {
36693669
mod_timer(&mp->timer, time);
36703670
}
36713671

@@ -3681,7 +3681,7 @@ br_multicast_leave_group(struct net_bridge_mcast *brmctx,
36813681
if (!hlist_unhashed(&p->mglist) &&
36823682
(timer_pending(&p->timer) ?
36833683
time_after(p->timer.expires, time) :
3684-
try_to_del_timer_sync(&p->timer) >= 0)) {
3684+
timer_delete_sync_try(&p->timer) >= 0)) {
36853685
mod_timer(&p->timer, time);
36863686
}
36873687

sound/pci/ctxfi/cttimer.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -119,7 +119,7 @@ static void ct_systimer_stop(struct ct_timer_instance *ti)
119119
static void ct_systimer_prepare(struct ct_timer_instance *ti)
120120
{
121121
ct_systimer_stop(ti);
122-
try_to_del_timer_sync(&ti->timer);
122+
timer_delete_sync_try(&ti->timer);
123123
}
124124

125125
#define ct_systimer_free ct_systimer_prepare

0 commit comments

Comments
 (0)