Skip to content

Commit 35bf430

Browse files
Henry Huanghtejun
authored andcommitted
sched_ext: initialize kit->cursor.flags
struct bpf_iter_scx_dsq *it maybe not initialized. If we didn't call scx_bpf_dsq_move_set_vtime and scx_bpf_dsq_move_set_slice before scx_bpf_dsq_move, it would cause unexpected behaviors: 1. Assign a huge slice into p->scx.slice 2. Assign a invalid vtime into p->scx.dsq_vtime Signed-off-by: Henry Huang <henry.hj@antgroup.com> Fixes: 6462dd5 ("sched_ext: Compact struct bpf_iter_scx_dsq_kern") Cc: stable@vger.kernel.org # v6.12 Signed-off-by: Tejun Heo <tj@kernel.org>
1 parent 18b2093 commit 35bf430

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

kernel/sched/ext.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7013,7 +7013,7 @@ __bpf_kfunc int bpf_iter_scx_dsq_new(struct bpf_iter_scx_dsq *it, u64 dsq_id,
70137013
return -ENOENT;
70147014

70157015
INIT_LIST_HEAD(&kit->cursor.node);
7016-
kit->cursor.flags |= SCX_DSQ_LNODE_ITER_CURSOR | flags;
7016+
kit->cursor.flags = SCX_DSQ_LNODE_ITER_CURSOR | flags;
70177017
kit->cursor.priv = READ_ONCE(kit->dsq->seq);
70187018

70197019
return 0;

0 commit comments

Comments
 (0)