Skip to content

Commit 263cb0c

Browse files
tititiou36Hans Verkuil
authored andcommitted
media: imx-mipi-csis: Remove an incorrect fwnode_handle_put() call
The commit in Fixes has removed an fwnode_graph_get_endpoint_by_id() call in mipi_csis_subdev_init(). So the reference that was taken should not be released anymore in the error handling path of the probe and in the remove function. Remove the now incorrect fwnode_handle_put() calls. Fixes: 1029939 ("media: v4l: async: Simplify async sub-device fwnode matching") Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Reviewed-by: Rui Miguel Silva <rmfrfs@gmail.com> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
1 parent 735de5c commit 263cb0c

File tree

1 file changed

+0
-2
lines changed

1 file changed

+0
-2
lines changed

drivers/media/platform/nxp/imx-mipi-csis.c

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1490,7 +1490,6 @@ static int mipi_csis_probe(struct platform_device *pdev)
14901490
v4l2_async_unregister_subdev(&csis->sd);
14911491
err_disable_clock:
14921492
mipi_csis_clk_disable(csis);
1493-
fwnode_handle_put(csis->sd.fwnode);
14941493

14951494
return ret;
14961495
}
@@ -1510,7 +1509,6 @@ static void mipi_csis_remove(struct platform_device *pdev)
15101509
mipi_csis_clk_disable(csis);
15111510
v4l2_subdev_cleanup(&csis->sd);
15121511
media_entity_cleanup(&csis->sd.entity);
1513-
fwnode_handle_put(csis->sd.fwnode);
15141512
pm_runtime_set_suspended(&pdev->dev);
15151513
}
15161514

0 commit comments

Comments
 (0)