Skip to content

Commit 245f3b1

Browse files
jmaneyrol-invnjic23
authored andcommitted
iio: imu: inv_icm42600: delete unneeded update watermark call
Update watermark will be done inside the hwfifo_set_watermark callback just after the update_scan_mode. It is useless to do it here. Fixes: 7f85e42 ("iio: imu: inv_icm42600: add buffer support in iio devices") Cc: stable@vger.kernel.org Signed-off-by: Jean-Baptiste Maneyrol <jean-baptiste.maneyrol@tdk.com> Link: https://lore.kernel.org/r/20240527210008.612932-1-inv.git-commit@tdk.com Signed-off-by: Jonathan Cameron <Jonathan.Cameron@huawei.com>
1 parent d7bd473 commit 245f3b1

File tree

2 files changed

+0
-8
lines changed

2 files changed

+0
-8
lines changed

drivers/iio/imu/inv_icm42600/inv_icm42600_accel.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -130,10 +130,6 @@ static int inv_icm42600_accel_update_scan_mode(struct iio_dev *indio_dev,
130130
/* update data FIFO write */
131131
inv_sensors_timestamp_apply_odr(ts, 0, 0, 0);
132132
ret = inv_icm42600_buffer_set_fifo_en(st, fifo_en | st->fifo.en);
133-
if (ret)
134-
goto out_unlock;
135-
136-
ret = inv_icm42600_buffer_update_watermark(st);
137133

138134
out_unlock:
139135
mutex_unlock(&st->lock);

drivers/iio/imu/inv_icm42600/inv_icm42600_gyro.c

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -130,10 +130,6 @@ static int inv_icm42600_gyro_update_scan_mode(struct iio_dev *indio_dev,
130130
/* update data FIFO write */
131131
inv_sensors_timestamp_apply_odr(ts, 0, 0, 0);
132132
ret = inv_icm42600_buffer_set_fifo_en(st, fifo_en | st->fifo.en);
133-
if (ret)
134-
goto out_unlock;
135-
136-
ret = inv_icm42600_buffer_update_watermark(st);
137133

138134
out_unlock:
139135
mutex_unlock(&st->lock);

0 commit comments

Comments
 (0)