Skip to content

Commit 23cef42

Browse files
Zhongqiu Hanmartinkpetersen
authored andcommitted
scsi: aha152x: Use DECLARE_COMPLETION_ONSTACK for non-constant completion
The _ONSTACK variant should be used for on-stack completion, otherwise it will break lockdep. See also commit 6e9a473 ("[PATCH] completions: lockdep annotate on stack completions"). Signed-off-by: Zhongqiu Han <quic_zhonhan@quicinc.com> Link: https://lore.kernel.org/r/20240705103614.3650637-1-quic_zhonhan@quicinc.com Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
1 parent 6ca9fed commit 23cef42

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/scsi/aha152x.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1072,7 +1072,7 @@ static int aha152x_abort(struct scsi_cmnd *SCpnt)
10721072
static int aha152x_device_reset(struct scsi_cmnd * SCpnt)
10731073
{
10741074
struct Scsi_Host *shpnt = SCpnt->device->host;
1075-
DECLARE_COMPLETION(done);
1075+
DECLARE_COMPLETION_ONSTACK(done);
10761076
int ret, issued, disconnected;
10771077
unsigned char old_cmd_len = SCpnt->cmd_len;
10781078
unsigned long flags;

0 commit comments

Comments
 (0)