Skip to content

Commit 1b0332a

Browse files
eleanorLYJFrederic Weisbecker
authored andcommitted
kthread: Fix return value on kzalloc() failure in kthread_affine_preferred()
kthread_affine_preferred() incorrectly returns 0 instead of -ENOMEM when kzalloc() fails. Return 'ret' to ensure the correct error code is propagated. Fixes: 4d13f43 ("kthread: Implement preferred affinity") Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202501301528.t0cZVbnq-lkp@intel.com/ Signed-off-by: Yu-Chun Lin <eleanor15x@gmail.com> Signed-off-by: Frederic Weisbecker <frederic@kernel.org>
1 parent 2014c95 commit 1b0332a

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

kernel/kthread.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -859,7 +859,7 @@ int kthread_affine_preferred(struct task_struct *p, const struct cpumask *mask)
859859
struct kthread *kthread = to_kthread(p);
860860
cpumask_var_t affinity;
861861
unsigned long flags;
862-
int ret;
862+
int ret = 0;
863863

864864
if (!wait_task_inactive(p, TASK_UNINTERRUPTIBLE) || kthread->started) {
865865
WARN_ON(1);
@@ -892,7 +892,7 @@ int kthread_affine_preferred(struct task_struct *p, const struct cpumask *mask)
892892
out:
893893
free_cpumask_var(affinity);
894894

895-
return 0;
895+
return ret;
896896
}
897897

898898
/*

0 commit comments

Comments
 (0)