Skip to content

Commit 1903e6d

Browse files
namjaejeonSteve French
authored andcommitted
ksmbd: fix potential double free on smb2_read_pipe() error path
Fix new smatch warnings: fs/smb/server/smb2pdu.c:6131 smb2_read_pipe() error: double free of 'rpc_resp' Fixes: e2b76ab ("ksmbd: add support for read compound") Reported-by: kernel test robot <lkp@intel.com> Reported-by: Dan Carpenter <dan.carpenter@linaro.org> Signed-off-by: Namjae Jeon <linkinjeon@kernel.org> Signed-off-by: Steve French <stfrench@microsoft.com>
1 parent 4148490 commit 1903e6d

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

fs/smb/server/smb2pdu.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6152,12 +6152,12 @@ static noinline int smb2_read_pipe(struct ksmbd_work *work)
61526152
memcpy(aux_payload_buf, rpc_resp->payload, rpc_resp->payload_sz);
61536153

61546154
nbytes = rpc_resp->payload_sz;
6155-
kvfree(rpc_resp);
61566155
err = ksmbd_iov_pin_rsp_read(work, (void *)rsp,
61576156
offsetof(struct smb2_read_rsp, Buffer),
61586157
aux_payload_buf, nbytes);
61596158
if (err)
61606159
goto out;
6160+
kvfree(rpc_resp);
61616161
} else {
61626162
err = ksmbd_iov_pin_rsp(work, (void *)rsp,
61636163
offsetof(struct smb2_read_rsp, Buffer));

0 commit comments

Comments
 (0)