Skip to content

Commit 18a5450

Browse files
committed
NFSD: Fix nfsdcld warning
Since CONFIG_NFSD_LEGACY_CLIENT_TRACKING is a new config option, its initial default setting should have been Y (if we are to follow the common practice of "default Y, wait, default N, wait, remove code"). Paul also suggested adding a clearer remedy action to the warning message. Reported-by: Paul Menzel <pmenzel@molgen.mpg.de> Message-Id: <d2ab4ee7-ba0f-44ac-b921-90c8fa5a04d2@molgen.mpg.de> Fixes: 74fd487 ("nfsd: new Kconfig option for legacy client tracking") Reviewed-by: Jeff Layton <jlayton@kernel.org> Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
1 parent d1b586e commit 18a5450

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

fs/nfsd/Kconfig

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -162,7 +162,7 @@ config NFSD_V4_SECURITY_LABEL
162162
config NFSD_LEGACY_CLIENT_TRACKING
163163
bool "Support legacy NFSv4 client tracking methods (DEPRECATED)"
164164
depends on NFSD_V4
165-
default n
165+
default y
166166
help
167167
The NFSv4 server needs to store a small amount of information on
168168
stable storage in order to handle state recovery after reboot. Most

fs/nfsd/nfs4recover.c

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2086,8 +2086,8 @@ nfsd4_client_tracking_init(struct net *net)
20862086
status = nn->client_tracking_ops->init(net);
20872087
out:
20882088
if (status) {
2089-
printk(KERN_WARNING "NFSD: Unable to initialize client "
2090-
"recovery tracking! (%d)\n", status);
2089+
pr_warn("NFSD: Unable to initialize client recovery tracking! (%d)\n", status);
2090+
pr_warn("NFSD: Is nfsdcld running? If not, enable CONFIG_NFSD_LEGACY_CLIENT_TRACKING.\n");
20912091
nn->client_tracking_ops = NULL;
20922092
}
20932093
return status;

0 commit comments

Comments
 (0)