Skip to content

Commit 1641472

Browse files
BrokenR3C0RDwens
authored andcommitted
clk: sunxi-ng: a100: enable MMC clock reparenting
While testing the MMC nodes proposed in [1], it was noted that mmc0/1 would fail to initialize, with "mmc: fatal err update clk timeout" in the kernel logs. A closer look at the clock definitions showed that the MMC MPs had the "CLK_SET_RATE_NO_REPARENT" flag set. No reason was given for adding this flag in the first place, and its original purpose is unknown, but it doesn't seem to make sense and results in severe limitations to MMC speeds. Thus, remove this flag from the 3 MMC MPs. [1] https://msgid.link/20241024170540.2721307-10-masterr3c0rd@epochal.quest Fixes: fb038ce ("clk: sunxi-ng: add support for the Allwinner A100 CCU") Cc: stable@vger.kernel.org Signed-off-by: Cody Eksal <masterr3c0rd@epochal.quest> Reviewed-by: Andre Przywara <andre.przywara@arm.com> Link: https://patch.msgid.link/20241109003739.3440904-1-masterr3c0rd@epochal.quest Signed-off-by: Chen-Yu Tsai <wens@csie.org>
1 parent 40384c8 commit 1641472

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

drivers/clk/sunxi-ng/ccu-sun50i-a100.c

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -436,23 +436,23 @@ static SUNXI_CCU_MP_WITH_MUX_GATE_POSTDIV(mmc0_clk, "mmc0", mmc_parents, 0x830,
436436
24, 2, /* mux */
437437
BIT(31), /* gate */
438438
2, /* post-div */
439-
CLK_SET_RATE_NO_REPARENT);
439+
0);
440440

441441
static SUNXI_CCU_MP_WITH_MUX_GATE_POSTDIV(mmc1_clk, "mmc1", mmc_parents, 0x834,
442442
0, 4, /* M */
443443
8, 2, /* P */
444444
24, 2, /* mux */
445445
BIT(31), /* gate */
446446
2, /* post-div */
447-
CLK_SET_RATE_NO_REPARENT);
447+
0);
448448

449449
static SUNXI_CCU_MP_WITH_MUX_GATE_POSTDIV(mmc2_clk, "mmc2", mmc_parents, 0x838,
450450
0, 4, /* M */
451451
8, 2, /* P */
452452
24, 2, /* mux */
453453
BIT(31), /* gate */
454454
2, /* post-div */
455-
CLK_SET_RATE_NO_REPARENT);
455+
0);
456456

457457
static SUNXI_CCU_GATE(bus_mmc0_clk, "bus-mmc0", "ahb3", 0x84c, BIT(0), 0);
458458
static SUNXI_CCU_GATE(bus_mmc1_clk, "bus-mmc1", "ahb3", 0x84c, BIT(1), 0);

0 commit comments

Comments
 (0)