Skip to content

Commit 107d55e

Browse files
qa-majeedrafaeljw
authored andcommitted
ACPI: scan: Use strscpy() instead of strcpy()
Replace strcpy() with strscpy() in the ACPI device enumeration code. strcpy() has been deprecated because it is generally unsafe, so it is better to eliminate it from the kernel source. Link: KSPP#88 Signed-off-by: Muhammad Qasim Abdul Majeed <qasim.majeed20@gmail.com> Link: https://patch.msgid.link/20240915183822.34588-9-qasim.majeed20@gmail.com [ rjw: Subject and changelog edits ] Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
1 parent 0dac2f7 commit 107d55e

File tree

1 file changed

+7
-7
lines changed

1 file changed

+7
-7
lines changed

drivers/acpi/scan.c

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1179,19 +1179,19 @@ static void acpi_device_get_busid(struct acpi_device *device)
11791179
* TBD: Shouldn't this value be unique (within the ACPI namespace)?
11801180
*/
11811181
if (!acpi_dev_parent(device)) {
1182-
strcpy(device->pnp.bus_id, "ACPI");
1182+
strscpy(device->pnp.bus_id, "ACPI");
11831183
return;
11841184
}
11851185

11861186
switch (device->device_type) {
11871187
case ACPI_BUS_TYPE_POWER_BUTTON:
1188-
strcpy(device->pnp.bus_id, "PWRF");
1188+
strscpy(device->pnp.bus_id, "PWRF");
11891189
break;
11901190
case ACPI_BUS_TYPE_SLEEP_BUTTON:
1191-
strcpy(device->pnp.bus_id, "SLPF");
1191+
strscpy(device->pnp.bus_id, "SLPF");
11921192
break;
11931193
case ACPI_BUS_TYPE_ECDT_EC:
1194-
strcpy(device->pnp.bus_id, "ECDT");
1194+
strscpy(device->pnp.bus_id, "ECDT");
11951195
break;
11961196
default:
11971197
acpi_get_name(device->handle, ACPI_SINGLE_NAME, &buffer);
@@ -1202,7 +1202,7 @@ static void acpi_device_get_busid(struct acpi_device *device)
12021202
else
12031203
break;
12041204
}
1205-
strcpy(device->pnp.bus_id, bus_id);
1205+
strscpy(device->pnp.bus_id, bus_id);
12061206
break;
12071207
}
12081208
}
@@ -1453,8 +1453,8 @@ static void acpi_set_pnp_ids(acpi_handle handle, struct acpi_device_pnp *pnp,
14531453
acpi_object_is_system_bus(handle)) {
14541454
/* \_SB, \_TZ, LNXSYBUS */
14551455
acpi_add_id(pnp, ACPI_BUS_HID);
1456-
strcpy(pnp->device_name, ACPI_BUS_DEVICE_NAME);
1457-
strcpy(pnp->device_class, ACPI_BUS_CLASS);
1456+
strscpy(pnp->device_name, ACPI_BUS_DEVICE_NAME);
1457+
strscpy(pnp->device_class, ACPI_BUS_CLASS);
14581458
}
14591459

14601460
break;

0 commit comments

Comments
 (0)