Skip to content

Commit 0769a8f

Browse files
committed
Merge tag 'platform-drivers-x86-v6.13-2' of git://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86
Pull x86 platform driver fixes from Ilpo Järvinen: - asus-nb-wmi: Silence unknown event warning when charger is plugged in - asus-wmi: Handle return code variations during thermal policy writing graciously - samsung-laptop: Correct module description * tag 'platform-drivers-x86-v6.13-2' of git://git.kernel.org/pub/scm/linux/kernel/git/pdx86/platform-drivers-x86: platform/x86: asus-nb-wmi: Ignore unknown event 0xCF platform/x86: asus-wmi: Ignore return value when writing thermal policy platform/x86: samsung-laptop: Match MODULE_DESCRIPTION() to functionality
2 parents feffde6 + e9fba20 commit 0769a8f

File tree

3 files changed

+4
-10
lines changed

3 files changed

+4
-10
lines changed

drivers/platform/x86/asus-nb-wmi.c

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -623,6 +623,7 @@ static const struct key_entry asus_nb_wmi_keymap[] = {
623623
{ KE_KEY, 0xC4, { KEY_KBDILLUMUP } },
624624
{ KE_KEY, 0xC5, { KEY_KBDILLUMDOWN } },
625625
{ KE_IGNORE, 0xC6, }, /* Ambient Light Sensor notification */
626+
{ KE_IGNORE, 0xCF, }, /* AC mode */
626627
{ KE_KEY, 0xFA, { KEY_PROG2 } }, /* Lid flip action */
627628
{ KE_KEY, 0xBD, { KEY_PROG2 } }, /* Lid flip action on ROG xflow laptops */
628629
{ KE_END, 0},

drivers/platform/x86/asus-wmi.c

Lines changed: 2 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -3696,7 +3696,6 @@ static int asus_wmi_custom_fan_curve_init(struct asus_wmi *asus)
36963696
/* Throttle thermal policy ****************************************************/
36973697
static int throttle_thermal_policy_write(struct asus_wmi *asus)
36983698
{
3699-
u32 retval;
37003699
u8 value;
37013700
int err;
37023701

@@ -3718,8 +3717,8 @@ static int throttle_thermal_policy_write(struct asus_wmi *asus)
37183717
value = asus->throttle_thermal_policy_mode;
37193718
}
37203719

3721-
err = asus_wmi_set_devstate(asus->throttle_thermal_policy_dev,
3722-
value, &retval);
3720+
/* Some machines do not return an error code as a result, so we ignore it */
3721+
err = asus_wmi_set_devstate(asus->throttle_thermal_policy_dev, value, NULL);
37233722

37243723
sysfs_notify(&asus->platform_device->dev.kobj, NULL,
37253724
"throttle_thermal_policy");
@@ -3729,12 +3728,6 @@ static int throttle_thermal_policy_write(struct asus_wmi *asus)
37293728
return err;
37303729
}
37313730

3732-
if (retval != 1) {
3733-
pr_warn("Failed to set throttle thermal policy (retval): 0x%x\n",
3734-
retval);
3735-
return -EIO;
3736-
}
3737-
37383731
/* Must set to disabled if mode is toggled */
37393732
if (asus->cpu_fan_curve_available)
37403733
asus->custom_fan_curves[FAN_CURVE_DEV_CPU].enabled = false;

drivers/platform/x86/samsung-laptop.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1653,5 +1653,5 @@ module_init(samsung_init);
16531653
module_exit(samsung_exit);
16541654

16551655
MODULE_AUTHOR("Greg Kroah-Hartman <gregkh@suse.de>");
1656-
MODULE_DESCRIPTION("Samsung Backlight driver");
1656+
MODULE_DESCRIPTION("Samsung Laptop driver");
16571657
MODULE_LICENSE("GPL");

0 commit comments

Comments
 (0)