Skip to content

Commit 062d59e

Browse files
nirmoyrodrigovivi
authored andcommitted
drm/xe: Fix access_ok check in user_fence_create
Check size of the data not size of the pointer. Reported-by: kernel test robot <lkp@intel.com> Closes: https://lore.kernel.org/oe-kbuild-all/202407300421.IBkAja96-lkp@intel.com/ Fixes: ddeb798 ("drm/xe: Validate user fence during creation") Cc: Matthew Auld <matthew.auld@intel.com> Cc: Matthew Brost <matthew.brost@intel.com> Reviewed-by: Matthew Auld <matthew.auld@intel.com> Reviewed-by: Tejas Upadhyay <tejas.upadhyay@intel.com> Reviewed-by: Apoorva Singh <apoorva.singh@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20240806110722.28661-1-nirmoy.das@intel.com Signed-off-by: Nirmoy Das <nirmoy.das@intel.com> (cherry picked from commit e102b5e) Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
1 parent 5e2d1d4 commit 062d59e

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

drivers/gpu/drm/xe/xe_sync.c

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ static struct xe_user_fence *user_fence_create(struct xe_device *xe, u64 addr,
5555
struct xe_user_fence *ufence;
5656
u64 __user *ptr = u64_to_user_ptr(addr);
5757

58-
if (!access_ok(ptr, sizeof(ptr)))
58+
if (!access_ok(ptr, sizeof(*ptr)))
5959
return ERR_PTR(-EFAULT);
6060

6161
ufence = kmalloc(sizeof(*ufence), GFP_KERNEL);

0 commit comments

Comments
 (0)