Skip to content

Commit 042c48b

Browse files
lucasdemarchirodrigovivi
authored andcommitted
drm/xe/devcoredump: Move exec queue snapshot to Contexts section
Having the exec queue snapshot inside a "GuC CT" section was always wrong. Commit c28fd6c ("drm/xe/devcoredump: Improve section headings and add tile info") tried to fix that bug, but with that also broke the mesa tool that parses the devcoredump, hence it was reverted in commit a53da2f ("drm/xe: Revert some changes that break a mesa debug tool"). With the mesa tool also fixed, this can propagate as a fix on both kernel and userspace side to avoid unnecessary headache for a debug feature. Cc: John Harrison <John.C.Harrison@Intel.com> Cc: Julia Filipchuk <julia.filipchuk@intel.com> Cc: José Roberto de Souza <jose.souza@intel.com> Cc: stable@vger.kernel.org Fixes: a53da2f ("drm/xe: Revert some changes that break a mesa debug tool") Reviewed-by: José Roberto de Souza <jose.souza@intel.com> Link: https://patchwork.freedesktop.org/patch/msgid/20250123051112.1938193-2-lucas.demarchi@intel.com Signed-off-by: Lucas De Marchi <lucas.demarchi@intel.com> (cherry picked from commit a37934e) Signed-off-by: Rodrigo Vivi <rodrigo.vivi@intel.com>
1 parent 990d35e commit 042c48b

File tree

1 file changed

+1
-5
lines changed

1 file changed

+1
-5
lines changed

drivers/gpu/drm/xe/xe_devcoredump.c

Lines changed: 1 addition & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -119,11 +119,7 @@ static ssize_t __xe_devcoredump_read(char *buffer, size_t count,
119119
drm_puts(&p, "\n**** GuC CT ****\n");
120120
xe_guc_ct_snapshot_print(ss->guc.ct, &p);
121121

122-
/*
123-
* Don't add a new section header here because the mesa debug decoder
124-
* tool expects the context information to be in the 'GuC CT' section.
125-
*/
126-
/* drm_puts(&p, "\n**** Contexts ****\n"); */
122+
drm_puts(&p, "\n**** Contexts ****\n");
127123
xe_guc_exec_queue_snapshot_print(ss->ge, &p);
128124

129125
drm_puts(&p, "\n**** Job ****\n");

0 commit comments

Comments
 (0)