Skip to content

Commit 0253dad

Browse files
ISCAS-Vulabdaeinki
authored andcommitted
drm/exynos/vidi: Remove redundant error handling in vidi_get_modes()
In the vidi_get_modes() function, if either drm_edid_dup() or drm_edid_alloc() fails, the function will immediately return 0, indicating that no display modes can be retrieved. However, in the event of failure in these two functions, it is still necessary to call the subsequent drm_edid_connector_update() function with a NULL drm_edid as an argument. This ensures that operations such as connector settings are performed in its callee function, _drm_edid_connector_property_update. To maintain the integrity of the operation, redundant error handling needs to be removed. Signed-off-by: Wentao Liang <vulab@iscas.ac.cn> Signed-off-by: Inki Dae <inki.dae@samsung.com>
1 parent cfa00a6 commit 0253dad

File tree

1 file changed

+0
-3
lines changed

1 file changed

+0
-3
lines changed

drivers/gpu/drm/exynos/exynos_drm_vidi.c

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -312,9 +312,6 @@ static int vidi_get_modes(struct drm_connector *connector)
312312
else
313313
drm_edid = drm_edid_alloc(fake_edid_info, sizeof(fake_edid_info));
314314

315-
if (!drm_edid)
316-
return 0;
317-
318315
drm_edid_connector_update(connector, drm_edid);
319316

320317
count = drm_edid_connector_add_modes(connector);

0 commit comments

Comments
 (0)