Skip to content

Commit 0020c9d

Browse files
andy-shevbroonie
authored andcommitted
spi: Deduplicate deferred probe checks in spi_probe()
Deduplicate deferred probe checks in spi_probe() and enable the error message for ACPI case as well. Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com> Link: https://patch.msgid.link/20241208195635.1271656-3-andriy.shevchenko@linux.intel.com Signed-off-by: Mark Brown <broonie@kernel.org>
1 parent b6ffe0e commit 0020c9d

File tree

1 file changed

+6
-11
lines changed

1 file changed

+6
-11
lines changed

drivers/spi/spi.c

Lines changed: 6 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -417,19 +417,14 @@ static int spi_probe(struct device *dev)
417417
if (ret)
418418
return ret;
419419

420-
if (is_of_node(fwnode)) {
420+
if (is_of_node(fwnode))
421421
spi->irq = of_irq_get(dev->of_node, 0);
422-
if (spi->irq == -EPROBE_DEFER)
423-
return dev_err_probe(dev, -EPROBE_DEFER, "Failed to get irq\n");
424-
if (spi->irq < 0)
425-
spi->irq = 0;
426-
} else if (is_acpi_device_node(fwnode) && spi->irq < 0) {
422+
else if (is_acpi_device_node(fwnode) && spi->irq < 0)
427423
spi->irq = acpi_dev_gpio_irq_get(to_acpi_device_node(fwnode), 0);
428-
if (spi->irq == -EPROBE_DEFER)
429-
return -EPROBE_DEFER;
430-
if (spi->irq < 0)
431-
spi->irq = 0;
432-
}
424+
if (spi->irq == -EPROBE_DEFER)
425+
return dev_err_probe(dev, spi->irq, "Failed to get irq\n");
426+
if (spi->irq < 0)
427+
spi->irq = 0;
433428

434429
ret = dev_pm_domain_attach(dev, true);
435430
if (ret)

0 commit comments

Comments
 (0)