Fix ignoral of non-existent paths

Author: zaneduffield

CHANGELOG.md

@@ -27,6 +27,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
 - `--config-file` no longer erroneously accepts a path to a directory and searches from it for a
   `pasfmt.toml` file. It is now an error to provide a path to a directory.
 - Detection of decoding errors when reading from stdin.
+- Silent ignoral of non-existent paths (were being treated as globs matching no files).
 
 ## [0.3.0] - 2024-05-29
 

orchestrator/src/file_formatter.rs

@@ -40,7 +40,7 @@ impl FileFormatter {
         warn!("'{}' is not a valid file path/glob", path);
     }
 
-    fn get_valid_files<S: AsRef<str>>(&self, paths: &[S]) -> Vec<PathBuf> {
+    fn find_files<S: AsRef<str>>(&self, paths: &[S]) -> Vec<PathBuf> {
         let mut valid_paths = vec![];
         paths.iter().map(AsRef::as_ref).for_each(|path_str| {
             let path = Path::new(path_str);
@@ -55,16 +55,16 @@ impl FileFormatter {
                         }
                     }));
                 }
-                Ok(metadata) if metadata.is_file() => {
-                    valid_paths.push(path.to_path_buf());
-                }
-                _ => match glob(path_str) {
+                _ if path_str.contains('*') => match glob(path_str) {
                     Err(_) => self.warn_invalid_glob(path_str),
                     Ok(glob) => glob.for_each(|entry| match entry {
                         Err(_) => self.warn_invalid_file(path_str),
                         Ok(path) => valid_paths.push(path),
                     }),
                 },
+                _ => {
+                    valid_paths.push(path.to_path_buf());
+                }
             }
         });
 
@@ -116,9 +116,7 @@ impl FileFormatter {
     {
         open_options.read(true);
 
-        let valid_paths: Vec<_> = self.get_valid_files(paths);
-
-        valid_paths
+        self.find_files(paths)
             .into_par_iter()
             .map_init(
                 || (Vec::<u8>::new(), String::new()),