Skip to content

Commit 67e388c

Browse files
committed
#1 clean up ready and prepare for release
1 parent 3a75838 commit 67e388c

File tree

4 files changed

+4
-8
lines changed

4 files changed

+4
-8
lines changed

README.md

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# SwiftyJSONAccelerator
22

3-
**(Alpha v0.0.1)**
3+
**(Alpha v0.0.2)**
44

55
![Logo](https://raw.githubusercontent.com/insanoid/SwiftyJSONAccelerator/master/SwiftyJSONAccelerator/Assets.xcassets/AppIcon.appiconset/Icon_32x32%402x.png)
66

@@ -24,13 +24,12 @@ Currently, the pattern is very similar to its Objective-C counterpart. It genera
2424

2525
## TODO
2626

27-
- Instead of taking a single element consider merging all the elements and decide what to do as a while.
28-
- Should also consider the case where the type is an `[[AnyObject],[AnyObject]...]` while handling arrays.
2927
- Handle blank array a bit better.
3028
- Better User Interface and icon.
3129
- Generate both `struct` and `class`.
3230
- Support for generation of models that do not need SwiftyJSON.
3331
- Add tests and integrate with Travis CI.
32+
- Create a Xcode plugin and a command line executor.
3433

3534
---
3635

SwiftyJSONAccelerator/Info.plist

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,11 +17,11 @@
1717
<key>CFBundlePackageType</key>
1818
<string>APPL</string>
1919
<key>CFBundleShortVersionString</key>
20-
<string>0.0.1</string>
20+
<string>0.0.2</string>
2121
<key>CFBundleSignature</key>
2222
<string>????</string>
2323
<key>CFBundleVersion</key>
24-
<string>1</string>
24+
<string>2</string>
2525
<key>LSMinimumSystemVersion</key>
2626
<string>$(MACOSX_DEPLOYMENT_TARGET)</string>
2727
<key>NSHumanReadableCopyright</key>

SwiftyJSONAccelerator/SJModelGenerator.swift

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,6 @@ public class ModelGenerator {
136136
// If the array has objects, then take the first one and proces it to generate a model.
137137
if jsonValue.arrayValue.count > 0 {
138138

139-
// TODO: Instead of taking a single element consider merging all the elements and decide what to do as a while.
140139
let subClassType = checkType(jsonValue.arrayValue[0])
141140

142141
// If the type is an object, generate a new model and also create appropriate initalizers, declarations and decoders.
@@ -153,7 +152,6 @@ public class ModelGenerator {
153152
decoders = decoders.stringByAppendingFormat("%@\n", decoderForVariable(variableName,key: stringConstantName, type: "[\(subClassType)]"))
154153
description = description.stringByAppendingFormat("%@\n", descriptionForPrimitiveVariableArray(variableName, key: stringConstantName))
155154
}
156-
// TODO: We should also consider a third case where the type is an [AnyObject] to achive complete redundancy handling.
157155

158156
} else {
159157

@@ -214,7 +212,6 @@ public class ModelGenerator {
214212

215213
} else if let object = parsedJSONObject.array {
216214
// Incase the first object was NOT a dictionary.
217-
// TODO: Instead of taking a single element consider merging all the elements and decide what to do as a while.
218215
let subClassType = checkType(object[0])
219216

220217
// If the type is an object then make it the base class and generate stuff.

preview.png

-56.7 KB
Loading

0 commit comments

Comments
 (0)