fix: use try/catch with potential unknown address #962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhyslbw
approved these changes
Oct 25, 2024
ljagiela
approved these changes
Oct 25, 2024
mkazlauskas
requested changes
Oct 25, 2024
mkazlauskas
requested changes
Oct 25, 2024
mchappell
force-pushed
the
fix/try-catch-bech32-casting
branch
from
90618ea to
f286ea4
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implement try/catch with null fallback to prevent nami crashing if
Loader.Cardano.Address.from_bech32(address);throws due to invalid string length, mixed formatting, or any other issueLW-11769