chore(all): disable promise/avoid-new eslint rule (#1062)

Author: szymonmaslowski

.eslintrc.js

@@ -30,11 +30,10 @@ module.exports = {
     'no-invalid-this': 0,
     'react/prop-types': 'off',
     'max-len': 'off', // prettier is already handling this automatically,
-    // note: prod webpack config strips console logs anyway, nevertheless
-    // we don't want the dev build to be spammed by needless logging
     '@typescript-eslint/no-explicit-any': ['error'],
     'no-console': ['error', { allow: ['warn', 'error', 'info', 'debug'] }],
-    'lodash/import-scope': ['error', 'method']
+    'lodash/import-scope': ['error', 'method'],
+    'promise/avoid-new': 'off',
   },
   overrides: [
     {

apps/browser-extension-wallet/src/features/dapp/components/Connect.tsx

@@ -67,7 +67,6 @@ const NonSSLBanner = () => {
 const authorize = (authorization: 'deny' | 'just-once' | 'allow', url: string) => {
   const api$ = of({
     allowOrigin(origin: cip30.Origin): Promise<'deny' | 'just-once' | 'allow'> {
-      /* eslint-disable-next-line promise/avoid-new */
       if (!url.startsWith(origin)) {
         return Promise.reject();
       }

apps/browser-extension-wallet/src/hooks/__tests__/useBuildDelegation.test.ts

@@ -49,7 +49,6 @@ jest.mock('../../stores', () => ({
   })
 }));
 
-// eslint-disable-next-line promise/avoid-new
 const flushPromises = () => new Promise(setImmediate);
 
 describe('Testing useBuildDelegation hook', () => {

apps/browser-extension-wallet/src/lib/scripts/background/util.ts

@@ -86,7 +86,6 @@ export const launchCip30Popup = async (url: string, windowType: Windows.CreateTy
 };
 
 const waitForTabLoad = (tab: Tabs.Tab) =>
-  // eslint-disable-next-line promise/avoid-new
   new Promise<void>((resolve) => {
     const listener = (tabId: number, changeInfo: Tabs.OnUpdatedChangeInfoType) => {
       // make sure the status is 'complete' and it's the right tab

apps/browser-extension-wallet/src/utils/__tests__/createQueue.test.ts

@@ -1,5 +1,4 @@
 /* eslint-disable @typescript-eslint/no-explicit-any */
-/* eslint-disable promise/avoid-new */
 import { createQueue, TaskQueue } from '../taskQueue';
 
 describe('createQueue', () => {

apps/browser-extension-wallet/src/utils/mocks/fake-api-request.ts

@@ -1,7 +1,6 @@
 const DEFAULT_TIMEOUT = 1000;
 
 export const fakeApiRequest = <TResponse>(response: TResponse, timeout = DEFAULT_TIMEOUT): Promise<TResponse> =>
-  // eslint-disable-next-line promise/avoid-new
   new Promise<TResponse>((resolve) => {
     setTimeout(() => resolve(response), timeout);
   });

apps/browser-extension-wallet/src/utils/taskQueue.ts

@@ -37,7 +37,6 @@ export const createQueue = (batchTasks: number, intervalBetweenBatch: number): T
         if (sent >= batchTasks) {
           // Reset the sent count
           sent = 0;
-          // eslint-disable-next-line promise/avoid-new
           await new Promise((resolve) => setTimeout(resolve, intervalBetweenBatch));
         }
         execute();

packages/cardano/src/wallet/lib/__tests__/get-block-info-by-hash.test.ts

@@ -1,7 +1,6 @@
 /* eslint-disable no-magic-numbers */
 /* eslint-disable @typescript-eslint/no-explicit-any */
 /* eslint-disable @typescript-eslint/no-unused-vars */
-/* eslint-disable promise/avoid-new */
 import '@testing-library/jest-dom';
 import { getBlockInfoByHash } from '../get-block-info-by-hash';
 import { stakepoolSearchProviderStub, mockedStakePools } from '../../test/mocks/StakepoolSearchProviderStub';

packages/cardano/src/wallet/lib/__tests__/get-inputs-value.test.ts

@@ -1,7 +1,6 @@
 /* eslint-disable no-magic-numbers */
 /* eslint-disable @typescript-eslint/no-explicit-any */
 /* eslint-disable @typescript-eslint/no-unused-vars */
-/* eslint-disable promise/avoid-new */
 /* eslint-disable max-len */
 /* eslint-disable sonarjs/no-identical-functions */
 import '@testing-library/jest-dom';

packages/cardano/src/wallet/test/mocks/AssetsProviderStub.ts

@@ -22,15 +22,13 @@ export const mockedAssets: Asset.AssetInfo[] = [
 ];
 
 export const assetsProviderStub = (assets: Asset.AssetInfo[] = mockedAssets): AssetProvider => ({
-  getAsset: jest.fn().mockImplementation(
-    ({ assetId }) =>
-      // eslint-disable-next-line promise/avoid-new
-      new Promise((resolve) => resolve(assets.find((asset) => asset.assetId === assetId) || assets[0]))
-  ),
-  getAssets: jest.fn().mockImplementation(
-    ({ assetIds }) =>
-      // eslint-disable-next-line promise/avoid-new
-      new Promise((resolve) => resolve(assets.filter((asset) => assetIds.includes(asset.assetId)) || assets[0]))
-  ),
+  getAsset: jest
+    .fn()
+    .mockImplementation(async ({ assetId }) => assets.find((asset) => asset.assetId === assetId) || assets[0]),
+  getAssets: jest
+    .fn()
+    .mockImplementation(
+      async ({ assetIds }) => assets.filter((asset) => assetIds.includes(asset.assetId)) || assets[0]
+    ),
   healthCheck: jest.fn().mockResolvedValue({ ok: true })
 });