Skip to content

Commit b3b1d06

Browse files
authored
fix: [lw-11875] remove status info from reward activity details (#1577)
1 parent 6f838b9 commit b3b1d06

File tree

5 files changed

+0
-36
lines changed

5 files changed

+0
-36
lines changed

apps/browser-extension-wallet/src/views/browser-view/features/activity/components/ActivityDetail.tsx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -136,7 +136,6 @@ export const ActivityDetail = ({ price }: ActivityDetailProps): ReactElement =>
136136
return (
137137
<RewardsDetails
138138
name={name}
139-
status={activityInfo.status}
140139
includedDate={activityInfo.activity.includedUtcDate}
141140
includedTime={activityInfo.activity.includedUtcTime}
142141
amountTransformer={amountTransformer}

packages/core/src/ui/components/ActivityDetail/RewardsDetails.tsx

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,6 @@ import React from 'react';
22
import cn from 'classnames';
33
import { Tooltip } from 'antd';
44
import styles from './TransactionDetails.module.scss';
5-
import { ActivityStatus } from '../Transaction';
65
import { Ellipsis } from '@lace/common';
76
import { ActivityDetailHeader } from './ActivityDetailHeader';
87
import { useTranslation } from 'react-i18next';
@@ -21,7 +20,6 @@ export type RewardsInfo = {
2120
export interface RewardsDetailsProps {
2221
name: string;
2322
headerDescription?: string;
24-
status: ActivityStatus.SPENDABLE;
2523
includedDate: string;
2624
includedTime: string;
2725
amountTransformer: (amount: string) => string;
@@ -32,7 +30,6 @@ export interface RewardsDetailsProps {
3230
export const RewardsDetails = ({
3331
name,
3432
headerDescription,
35-
status,
3633
includedDate,
3734
includedTime,
3835
amountTransformer,
@@ -117,14 +114,6 @@ export const RewardsDetails = ({
117114
</div>
118115
)}
119116

120-
<div className={styles.details}>
121-
<div className={styles.title} data-testid="rewards-status-title">
122-
{t('core.activityDetails.status')}
123-
</div>
124-
<div data-testid="rewards-status" className={styles.detail}>{`${status
125-
.charAt(0)
126-
.toUpperCase()}${status.slice(1)}`}</div>
127-
</div>
128117
<div className={styles.details}>
129118
<div className={styles.title} data-testid="rewards-epoch-title">
130119
{t('core.activityDetails.epoch')}

packages/core/src/ui/components/ActivityDetail/__tests__/RewardsDetails.test.tsx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -3,13 +3,11 @@ import * as React from 'react';
33
import { render } from '@testing-library/react';
44
import '@testing-library/jest-dom';
55
import { RewardsDetails, RewardsDetailsProps } from '../RewardsDetails';
6-
import { ActivityStatus } from '../../Transaction';
76

87
describe('Testing ActivityDetailsBrowser component', () => {
98
const rewardsDetailsProps: RewardsDetailsProps = {
109
name: 'Name',
1110
headerDescription: 'Header Description',
12-
status: ActivityStatus.SPENDABLE,
1311
includedDate: 'Date',
1412
includedTime: 'Time',
1513
amountTransformer: (amount) => `${amount} $`,

packages/e2e-tests/src/assert/transactionDetailsAssert.ts

Lines changed: 0 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -431,18 +431,6 @@ class TransactionsDetailsAssert {
431431
await this.assertSeeRewardsStakePoolsSection();
432432
await this.assertSeeRewardsSinglePool();
433433

434-
await TransactionDetailsPage.transactionDetailsRewardsStatusTitle.waitForDisplayed();
435-
expect(await TransactionDetailsPage.transactionDetailsRewardsStatusTitle.getText()).to.equal(
436-
await t('core.activityDetails.status')
437-
);
438-
await TransactionDetailsPage.transactionDetailsRewardsStatus.waitForDisplayed();
439-
expect(await TransactionDetailsPage.transactionDetailsRewardsStatus.getText()).to.be.oneOf([
440-
'Spendable',
441-
'Success',
442-
'Sending',
443-
'Error'
444-
]);
445-
446434
await TransactionDetailsPage.transactionDetailsRewardsEpochTitle.waitForDisplayed();
447435
expect(await TransactionDetailsPage.transactionDetailsRewardsEpochTitle.getText()).to.equal(
448436
await t('core.activityDetails.epoch')

packages/e2e-tests/src/elements/transactionDetails.ts

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -58,8 +58,6 @@ class ActivityDetailsPage extends CommonDrawerElements {
5858
private TRANSACTION_DETAILS_REWARDS_POOL_ID = '[data-testid="rewards-pool-id"]';
5959
private TRANSACTION_DETAILS_REWARDS_SINGLE_POOL_ADA = '[data-testid="rewards-pool-reward-ada"]';
6060
private TRANSACTION_DETAILS_REWARDS_SINGLE_POOL_FIAT = '[data-testid="rewards-pool-reward-fiat"]';
61-
private TRANSACTION_DETAILS_REWARDS_STATUS_TITLE = '[data-testid="rewards-status-title"]';
62-
private TRANSACTION_DETAILS_REWARDS_STATUS = '[data-testid="rewards-status"]';
6361
private TRANSACTION_DETAILS_REWARDS_EPOCH_TITLE = '[data-testid="rewards-epoch-title"]';
6462
private TRANSACTION_DETAILS_REWARDS_EPOCH = '[data-testid="rewards-epoch"]';
6563
private TRANSACTION_DETAILS_REWARDS_TIMESTAMP_TITLE = '[data-testid="rewards-date-title"]';
@@ -305,14 +303,6 @@ class ActivityDetailsPage extends CommonDrawerElements {
305303
return $$(this.TRANSACTION_DETAILS_REWARDS_SINGLE_POOL_FIAT);
306304
}
307305

308-
get transactionDetailsRewardsStatusTitle(): ChainablePromiseElement<WebdriverIO.Element> {
309-
return $(this.TRANSACTION_DETAILS_REWARDS_STATUS_TITLE);
310-
}
311-
312-
get transactionDetailsRewardsStatus(): ChainablePromiseElement<WebdriverIO.Element> {
313-
return $(this.TRANSACTION_DETAILS_REWARDS_STATUS);
314-
}
315-
316306
get transactionDetailsRewardsEpochTitle(): ChainablePromiseElement<WebdriverIO.Element> {
317307
return $(this.TRANSACTION_DETAILS_REWARDS_EPOCH_TITLE);
318308
}

0 commit comments

Comments
 (0)