fix(all): [LW-8723] fix incorrect deletion of background storage (#703)

* fix(all): fix incorrect deletion of background storage

* fix(all): drop `analyticsAccepted` key from local storage when deleting wallet

* fix(all): add TODO comment

* fix(all): fix unit tests

Author: refi93

apps/browser-extension-wallet/src/hooks/__tests__/useWalletManager.test.tsx

@@ -758,15 +758,7 @@ describe('Testing useWalletManager hook', () => {
       await deleteWallet();
       expect(shutdownWalletMocked).toBeCalledWith(walletManagerUi);
       expect(clearLocalStorage).toBeCalledWith({
-        except: [
-          'currency',
-          'lock',
-          'mode',
-          'hideBalance',
-          'analyticsAccepted',
-          'isForgotPasswordFlow',
-          'multidelegationFirstVisit'
-        ]
+        except: ['currency', 'lock', 'mode', 'hideBalance', 'isForgotPasswordFlow', 'multidelegationFirstVisit']
       });
       expect(clearBackgroundStorage).toBeCalledWith({
         except: ['fiatPrices', 'userId', 'usePersistentUserId', 'experimentsConfiguration']

apps/browser-extension-wallet/src/hooks/useWalletManager.ts

@@ -315,7 +315,6 @@ export const useWalletManager = (): UseWalletManager => {
         'lock',
         'mode',
         'hideBalance',
-        'analyticsAccepted',
         'isForgotPasswordFlow',
         'multidelegationFirstVisit'
       ];

apps/browser-extension-wallet/src/lib/scripts/background/util.ts

@@ -60,10 +60,11 @@ export const clearBackgroundStorage = async (options?: ClearBackgroundStorageOpt
     if (options.keys && options.keys.includes(key as BackgroundStorageKeys)) {
       delete backgroundStorage[key as BackgroundStorageKeys];
     }
-    if (options.except && options.except.includes(key as BackgroundStorageKeys)) {
+    if (options.except && !options.except.includes(key as BackgroundStorageKeys)) {
       delete backgroundStorage[key as BackgroundStorageKeys];
     }
   }
+  // TODO make sure to remove other properties from webStorage (e.g. "lace-activate" seems to remain after clearing)
   await webStorage.local.set({ BACKGROUND_STORAGE: backgroundStorage ?? {} });
 };