test(extension): e2e fixes (#1038)

oldGreg5 · web-flow · commit 7001d6c0c862 · 2024-04-08T13:29:42.000Z
diff --git a/packages/e2e-tests/src/assert/transactionDetailsAssert.ts b/packages/e2e-tests/src/assert/transactionDetailsAssert.ts
@@ -25,6 +25,8 @@ export type TransactionData = {
   assets?: string[];
 };
 
+const stakeKeyRegistration = 'Stake Key Registration';
+
 class TransactionsDetailsAssert {
   waitForTransactionsLoaded = async () => {
     await browser.waitUntil(async () => (await TransactionsPage.rows).length > 1, {
@@ -114,7 +116,7 @@ class TransactionsDetailsAssert {
       await TransactionDetailsPage.transactionDetailsInputsSection.waitForDisplayed();
       await TransactionDetailsPage.transactionDetailsOutputsSection.waitForDisplayed();
       const txType = await TransactionDetailsPage.transactionDetailsDescription.getText();
-      if (!txType.includes('Stake Key Registration')) {
+      if (!txType.includes(stakeKeyRegistration)) {
         await TransactionDetailsPage.transactionDetailsFeeADA.waitForDisplayed();
         await TransactionDetailsPage.transactionDetailsFeeFiat.waitForDisplayed();
       }
@@ -164,6 +166,7 @@ class TransactionsDetailsAssert {
 
       const txDetailsInputADAValueString = await TransactionDetailsPage.transactionDetailsInputAdaAmount.getText();
       const txDetailsInputADAValue = Number(txDetailsInputADAValueString.split(' ', 1));
+      const txType = await TransactionDetailsPage.transactionDetailsDescription.getText();
 
       const txDetailsInputFiatValueString = await TransactionDetailsPage.transactionDetailsInputFiatAmount.getText();
       const txDetailsInputFiatValue = Number(txDetailsInputFiatValueString.slice(1).split(' ', 1));
@@ -174,18 +177,20 @@ class TransactionsDetailsAssert {
       const txDetailsOutputFiatValueString = await TransactionDetailsPage.transactionDetailsOutputFiatAmount.getText();
       const txDetailsOutputFiatValue = Number(txDetailsOutputFiatValueString.slice(1).split(' ', 1));
 
-      const txDetailsFeeADAValueString = await TransactionDetailsPage.transactionDetailsFeeADA.getText();
-      const txDetailsFeeADAValue = Number(txDetailsFeeADAValueString.split(' ', 1));
+      if (!txType.includes(stakeKeyRegistration)) {
+        const txDetailsFeeADAValueString = await TransactionDetailsPage.transactionDetailsFeeADA.getText();
+        const txDetailsFeeADAValue = Number(txDetailsFeeADAValueString.split(' ', 1));
+        expect(txDetailsFeeADAValue).to.be.greaterThan(0);
 
-      const txDetailsFeeFiatValueString = await TransactionDetailsPage.transactionDetailsFeeFiat.getText();
-      const txDetailsFeeFiatValue = Number(txDetailsFeeFiatValueString.slice(1).split(' ', 1));
+        const txDetailsFeeFiatValueString = await TransactionDetailsPage.transactionDetailsFeeFiat.getText();
+        const txDetailsFeeFiatValue = Number(txDetailsFeeFiatValueString.slice(1).split(' ', 1));
+        expect(txDetailsFeeFiatValue).to.be.greaterThan(0);
+      }
 
       expect(txDetailsInputADAValue).to.be.greaterThan(0);
       expect(txDetailsInputFiatValue).to.be.greaterThan(0);
       expect(txDetailsOutputADAValue).to.be.greaterThan(0);
       expect(txDetailsOutputFiatValue).to.be.greaterThan(0);
-      expect(txDetailsFeeADAValue).to.be.greaterThan(0);
-      expect(txDetailsFeeFiatValue).to.be.greaterThan(0);
 
       await TransactionDetailsPage.closeActivityDetails(mode);
     }
@@ -221,8 +226,8 @@ class TransactionsDetailsAssert {
       if ((await TransactionsPage.transactionsTableItemType(i).getText()) !== 'Self Transaction') {
         await TransactionsPage.clickOnTransactionRow(i);
         await TransactionDetailsPage.transactionDetailsDescription.waitForClickable({ timeout: 15_000 });
-        const txType = await TransactionDetailsPage.transactionDetailsDescription.getText();
-        if (!txType.includes('Delegation')) {
+        const txType = (await TransactionDetailsPage.transactionDetailsDescription.getText()).split('\n')[0];
+        if (!['Delegation', stakeKeyRegistration].includes(txType)) {
           const tokensAmountSummary =
             (await TransactionDetailsPage.getTransactionSentTokensWithoutDuplicates()).length + 1;
           let tokensDescriptionAmount = await TransactionDetailsPage.transactionDetailsAmountOfTokens.getText();
diff --git a/packages/e2e-tests/src/elements/onboarding/mainPage.ts b/packages/e2e-tests/src/elements/onboarding/mainPage.ts
@@ -1,4 +1,4 @@
-import { TestWalletName, getTestWallet } from '../../support/walletConfiguration';
+import { getTestWallet, TestWalletName } from '../../support/walletConfiguration';
 import CommonOnboardingElements from './commonOnboardingElements';
 import recoveryPhrasePage from './recoveryPhrasePage';
 import walletSetupPage from './walletSetupPage';
diff --git a/packages/e2e-tests/src/features/OnboardingCreateWallet.feature b/packages/e2e-tests/src/features/OnboardingCreateWallet.feature
@@ -210,9 +210,9 @@ Feature: Onboarding - Create wallet
       | 21    | is           | disabled    |
 
   @LW-5844
-  Scenario Outline: "Get started" page - Legal links - click on <legal_link> link
+  Scenario Outline: "Get started" page - Legal links in footer - click on <legal_link> link
     When "Get started" page is displayed
-    And I click on "<legal_link>" legal link on "Main page"
+    And I click on "<legal_link>" legal link
     Then "<legal_link>" is displayed in new tab
     Examples:
       | legal_link       |
diff --git a/packages/e2e-tests/src/features/SendTransactionBundlesExtended.feature b/packages/e2e-tests/src/features/SendTransactionBundlesExtended.feature
@@ -139,7 +139,7 @@ Feature: Send - Extended Browser View (Advanced Tx)
     And click on the coin selector for "tADA" asset in bundle 2
     And click on an token with name: "LaceCoin"
     And I enter a value of: 1 to the "LaceCoin1" asset in bundle 2
-    Then transaction fee is around 0.19 ADA and Ada allocation cost is around 1.07 ADA
+    Then transaction fee is around 0.25 ADA and Ada allocation cost is around 1.07 ADA
 
   @LW-4505
   Scenario: Extended-view - Cancel transaction with multiple bundles on Summary page
diff --git a/packages/e2e-tests/src/features/SendTransactionSimpleExtended.part1.feature b/packages/e2e-tests/src/features/SendTransactionSimpleExtended.part1.feature
@@ -189,7 +189,7 @@ Feature: LW-484: Send & Receive - Extended Browser View (Simple Tx)
     Then I verify transaction costs amount is around 0.00 ADA
     And I enter a valid "shelley" address in the bundle 1 recipient's address
     When I enter a value of: 2 to the "tADA" asset
-    Then I verify transaction costs amount is around 0.18 ADA
+    Then I verify transaction costs amount is around 0.25 ADA
 
   @LW-2370 @Testnet @Mainnet
   Scenario: Extended-view - Tx summary page is displayed
diff --git a/packages/e2e-tests/src/features/SendTransactionSimpleExtended.part2.feature b/packages/e2e-tests/src/features/SendTransactionSimpleExtended.part2.feature
@@ -176,7 +176,8 @@ Feature: LW-484: Send & Receive - Extended Browser View (Simple Tx)
     When I hover over the value for "tADA" asset in bundle 1
     Then the "MAX" button is not displayed
 
-  @LW-4762 @Testnet @Mainnet
+  @LW-4762 @Testnet @Mainnet @Pending
+  @issue=LW-10242
   Scenario: Extended View - Send flow - Enter and Escape buttons support
     When I click "Send" button on page header
     And I press keyboard Enter button
diff --git a/packages/e2e-tests/src/features/SendTransactionSimplePopup.part1.feature b/packages/e2e-tests/src/features/SendTransactionSimplePopup.part1.feature
@@ -182,7 +182,7 @@ Feature: LW-484: Send & Receive - Popup View (Simple Tx)
     Then I verify transaction costs amount is around 0.00 ADA
     And I enter a valid "shelley" address in the bundle 1 recipient's address
     When I enter a value of: 2 to the "tADA" asset in bundle 1
-    Then I verify transaction costs amount is around 0.18 ADA
+    Then I verify transaction costs amount is around 0.25 ADA
 
   @LW-2404 @Testnet @Mainnet
   Scenario: Popup-view - Tx summary page is displayed - single asset (ADA)
diff --git a/packages/e2e-tests/src/features/SettingsPageExtended.feature b/packages/e2e-tests/src/features/SettingsPageExtended.feature
@@ -2,7 +2,7 @@
 Feature: General Settings - Extended Browser View
 
   Background:
-    Given Lace is ready for test
+    Given Wallet is synced
 
   @LW-2324 @Smoke @Mainnet @Testnet
   Scenario: Extended View - Visibility of Settings page and its content
diff --git a/packages/e2e-tests/src/features/TokensPageExtended.feature b/packages/e2e-tests/src/features/TokensPageExtended.feature
@@ -71,7 +71,8 @@ Feature: LW: Tokens tab - extended view
       | FAQ      | What type of governance features are supported in Lace using the GovTool in the current SanchoNet test environment? |
       | FAQ      | What type of governance actions are supported by Lace?                                                              |
 
-  @LW-4878 @Testnet @Mainnet
+  @LW-4878 @Testnet @Mainnet @Pending
+  @issue=LW-10242
   Scenario: Extended-view - Tokens details - Enter and Escape buttons support
     And I click token with name: "Cardano"
     And The Token details screen is displayed for token "Cardano" with ticker "tADA" in extended mode

Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { TestWalletName, getTestWallet } from '../../support/walletConfiguration';`
	`1`	`+import { getTestWallet, TestWalletName } from '../../support/walletConfiguration';`
`2`	`2`	`import CommonOnboardingElements from './commonOnboardingElements';`
`3`	`3`	`import recoveryPhrasePage from './recoveryPhrasePage';`
`4`	`4`	`import walletSetupPage from './walletSetupPage';`