ci: build artifacts for firefox and ms edge submission (#1894)

* ci: update firefox release workflow

* ci: build and upload ms edge artifact

Author: pczeglik-iohk

.github/actions/build/app/action.yml

@@ -67,7 +67,7 @@ inputs:
     required: false
     default: ''
   BROWSER_TARGET:
-    description: 'Browser target to build for. Options are [firefox | chromium]'
+    description: 'Browser target to build for. Options are [chromium | firefox]'
     required: false
     default: 'chromium'
 
@@ -103,14 +103,27 @@ runs:
         SENTRY_ENVIRONMENT: ${{ inputs.SENTRY_ENVIRONMENT }}
         BROWSER: ${{ inputs.BROWSER_TARGET }}
 
-    - name: Upload artifact
-      if: ${{ inputs.BROWSER_TARGET != 'firefox' }}
+    - name: Upload Chrome artifact
+      if: ${{ inputs.BROWSER_TARGET == 'chromium' }}
       uses: actions/upload-artifact@v4
       with:
-        name: ${{ inputs.NAME }}
+        name: lace-chrome-browser-extension
+        path: ${{ inputs.DIR }}/dist
+
+    - name: Prepare MS Edge
+      if: ${{ inputs.BROWSER_TARGET == 'chromium' }}
+      run: 'sed -i "s/\"key\": \"[^\"]*\",//" manifest.json'
+      shell: bash
+      working-directory: ${{ inputs.DIR }}/dist
+
+    - name: Upload MS Edge artifact
+      if: ${{ inputs.BROWSER_TARGET == 'chromium' }}
+      uses: actions/upload-artifact@v4
+      with:
+        name: lace-edge-browser-extension
         path: ${{ inputs.DIR }}/dist
 
-    - name: Pack Firefox
+    - name: Prepare Firefox
       if: ${{ inputs.BROWSER_TARGET == 'firefox' }}
       run: yarn pack:firefox
       shell: bash

.github/workflows/ci.yml

@@ -17,7 +17,7 @@ concurrency:
   cancel-in-progress: ${{ github.ref != 'refs/heads/main' }}
 
 env:
-  BUILD_ARTIFACT_NAME: 'lace-dev-${{ github.sha }}'
+  BUILD_ARTIFACT_NAME: 'lace-chrome-browser-extension-for-smoke-tests-${{ github.sha }}'
 
 jobs:
   prepare:
@@ -148,8 +148,8 @@ jobs:
       - name: Execute unit tests
         uses: ./.github/actions/test/unit
 
-  release-pkg:
-    name: Release package
+  release-chromium-pkg:
+    name: Release Chromium package
     runs-on: ubuntu-22.04
     needs: prepare
 
@@ -210,7 +210,7 @@ jobs:
         with:
           comment_on_pr: false
 
-      - name: Build Lace browser extension
+      - name: Build Lace Chromium browser extension
         uses: ./.github/actions/build/app
         with:
           BLOCKFROST_PROJECT_ID_MAINNET: ${{ secrets.BLOCKFROST_PROJECT_ID_MAINNET }}
@@ -219,7 +219,7 @@ jobs:
           MAESTRO_PROJECT_ID_MAINNET: ${{ secrets.MAESTRO_PROJECT_ID_MAINNET }}
           MAESTRO_PROJECT_ID_TESTNET: ${{ secrets.MAESTRO_PROJECT_ID_TESTNET }}
           DIR: apps/browser-extension-wallet
-          NAME: lace-browser-extension
+          NAME: lace-chrome-browser-extension
           LACE_EXTENSION_KEY: ${{ secrets.MANIFEST_PUBLIC_KEY }}
           POSTHOG_PRODUCTION_TOKEN: ${{ startsWith(github.ref, 'refs/heads/release') && secrets.POSTHOG_PRODUCTION_TOKEN || '' }}
           PRODUCTION_MODE_TRACKING: ${{ startsWith(github.ref, 'refs/heads/release') && 'true' || 'false' }}
@@ -231,7 +231,69 @@ jobs:
           SENTRY_ENVIRONMENT: 'production'
           DAPP_RADAR_API_KEY: ${{ startsWith(github.ref, 'refs/heads/release') && secrets.DAPP_RADAR_API_KEY || '' }}
 
-      - name: Build Lace Firefox addon
+  release-firefox-pkg:
+    name: Release Firefox package
+    runs-on: ubuntu-22.04
+    needs: prepare
+
+    steps:
+      - name: Checkout repository
+        uses: actions/checkout@v4
+
+      - name: Setup Node.js and install dependencies
+        uses: ./.github/actions/install
+        with:
+          WALLET_PASSWORD: ${{ secrets.WALLET_PASSWORD_TESTNET }}
+          GITHUB_TOKEN: ${{ secrets.GH_TOKEN }}
+
+      - name: Download packages-common
+        uses: actions/download-artifact@v4
+        with:
+          name: packages-common
+          path: packages/common/dist
+
+      - name: Download packages-cardano
+        uses: actions/download-artifact@v4
+        with:
+          name: packages-cardano
+          path: packages/cardano/dist
+
+      - name: Download packages-translation
+        uses: actions/download-artifact@v4
+        with:
+          name: packages-translation
+          path: packages/translation/dist
+
+      - name: Download packages-core
+        uses: actions/download-artifact@v4
+        with:
+          name: packages-core
+          path: packages/core/dist
+
+      - name: Download packages-staking
+        uses: actions/download-artifact@v4
+        with:
+          name: packages-staking
+          path: packages/staking/dist
+
+      - name: Download packages-nami
+        uses: actions/download-artifact@v4
+        with:
+          name: packages-nami
+          path: packages/nami/dist
+
+      - name: Download packages-bitcoin
+        uses: actions/download-artifact@v4
+        with:
+          name: packages-bitcoin
+          path: packages/bitcoin/dist
+
+      - name: Collect Workflow Telemetry Smoke Tests
+        uses: catchpoint/workflow-telemetry-action@v2
+        with:
+          comment_on_pr: false
+
+      - name: Build Lace Firefox browser extension
         uses: ./.github/actions/build/app
         with:
           BROWSER_TARGET: 'firefox'
@@ -241,7 +303,7 @@ jobs:
           MAESTRO_PROJECT_ID_MAINNET: ${{ secrets.MAESTRO_PROJECT_ID_MAINNET }}
           MAESTRO_PROJECT_ID_TESTNET: ${{ secrets.MAESTRO_PROJECT_ID_TESTNET }}
           DIR: apps/browser-extension-wallet
-          NAME: lace-firefox-addon
+          NAME: lace-firefox-browser-extension
           LACE_EXTENSION_KEY: ${{ secrets.MANIFEST_PUBLIC_KEY }}
           POSTHOG_PRODUCTION_TOKEN: ${{ startsWith(github.ref, 'refs/heads/release') && secrets.POSTHOG_PRODUCTION_TOKEN || '' }}
           PRODUCTION_MODE_TRACKING: ${{ startsWith(github.ref, 'refs/heads/release') && 'true' || 'false' }}
@@ -254,7 +316,7 @@ jobs:
           DAPP_RADAR_API_KEY: ${{ startsWith(github.ref, 'refs/heads/release') && secrets.DAPP_RADAR_API_KEY || '' }}
 
   build:
-    name: Build Lace
+    name: Build Lace for E2E Tests
     runs-on: ubuntu-22.04
 
     steps:

apps/browser-extension-wallet/package.json

@@ -37,12 +37,12 @@
     "cleanup:firefox-artifacts": "rm -rf artifacts-firefox",
     "cleanup:node_modules": "rm -rf node_modules",
     "dev": "run-s cleanup:dist dev:project",
-    "dev:firefox": "BROWSER=firefox run-s cleanup:dist dev:project ",
+    "dev:firefox": "BROWSER=firefox run-s cleanup:dist dev:project  ",
     "dev:project": "run-p watch:sw serve:app",
     "format-check": "echo \"@lace/browser-extension-wallet: no format-check command specified\"",
     "lint": "cd ../.. && yarn extension:lint",
     "prepack": "yarn build",
-    "pack:firefox": "run-s cleanup:firefox-artifacts && web-ext build --source-dir=dist --artifacts-dir=artifacts-firefox",
+    "pack:firefox": "run-s cleanup:firefox-artifacts && web-ext build --source-dir=./dist/ --filename=lace-firefox-browser-extension.zip --artifacts-dir=artifacts-firefox && unzip -o artifacts-firefox/lace-firefox-browser-extension.zip -d artifacts-firefox && rm -rf artifacts-firefox/lace-firefox-browser-extension.zip",
     "prepare": "ts-patch install -s",
     "prettier": "run -T prettier --write .",
     "serve:app": "NODE_OPTIONS='--openssl-legacy-provider' run -T webpack serve --config webpack.app.dev.js --env RUN_DEV_SERVER=true",

apps/browser-extension-wallet/webpack-utils.js

@@ -60,7 +60,7 @@ const transformManifest = (content, mode, jsAssets = []) => {
     if (process.env.BROWSER === 'firefox') {
       manifest.browser_specific_settings = {
         gecko: {
-          id: 'lace-wallet@lace.io',
+          id: 'lace-wallet-ext@lace.io',
           strict_min_version: '134.0'
         }
       };