fix(extension): [LW-11506] limit message signing to supported wallet types (#1425)

Author: mchappell

apps/browser-extension-wallet/src/components/MainMenu/DropdownMenuOverlay/DropdownMenuOverlay.tsx

@@ -1,4 +1,4 @@
-import React, { ReactNode, useCallback, useState, VFC } from 'react';
+import React, { ReactNode, useCallback, useState, VFC, useMemo } from 'react';
 import { Menu, MenuProps } from 'antd';
 import {
   AddNewWalletLink,
@@ -20,7 +20,8 @@ import { WalletAccounts } from './components/WalletAccounts';
 import { AddSharedWalletLink } from '@components/MainMenu/DropdownMenuOverlay/components/AddSharedWalletLink';
 import { useWalletStore } from '@stores';
 import classNames from 'classnames';
-import { AnyBip32Wallet } from '@cardano-sdk/web-extension';
+import type { AnyBip32Wallet } from '@cardano-sdk/web-extension';
+import { WalletType } from '@cardano-sdk/web-extension';
 import { Wallet } from '@lace/cardano';
 
 interface Props extends MenuProps {
@@ -39,7 +40,7 @@ export const DropdownMenuOverlay: VFC<Props> = ({
   ...props
 }): React.ReactElement => {
   const [currentSection, setCurrentSection] = useState<Sections>(Sections.Main);
-  const { environmentName, setManageAccountsWallet } = useWalletStore();
+  const { environmentName, setManageAccountsWallet, walletType } = useWalletStore();
 
   const openWalletAccounts = (wallet: AnyBip32Wallet<Wallet.WalletMetadata, Wallet.AccountMetadata>) => {
     setManageAccountsWallet(wallet);
@@ -62,6 +63,14 @@ export const DropdownMenuOverlay: VFC<Props> = ({
     </>
   );
 
+  const shouldShowSignMessage = useMemo(
+    () =>
+      process.env.USE_MESSAGE_SIGNING === 'true' &&
+      !isPopup &&
+      [WalletType.InMemory, WalletType.Ledger].includes(walletType),
+    [isPopup, walletType]
+  );
+
   return (
     <Menu {...props} className={styles.menuOverlay} data-testid="header-menu">
       {currentSection === Sections.Main && (
@@ -80,7 +89,7 @@ export const DropdownMenuOverlay: VFC<Props> = ({
             <AddressBookLink />
             <SettingsLink />
             <Separator />
-            {process.env.USE_MESSAGE_SIGNING === 'true' && !isPopup && getSignMessageLink()}
+            {shouldShowSignMessage && getSignMessageLink()}
             <ThemeSwitcher isPopup={isPopup} />
             <NetworkChoise onClick={handleNetworkChoise} />
             {lockWalletButton && (