test(extension): test maintenance, add retry for authorization window… (#685)

* test(extension): test maintenance, add retry for authorization window in dapp

* test(extension): apply comments

* test(extension): apply comments

Author: bslabiak

packages/e2e-tests/src/assert/drawerSendExtendedAssert.ts

@@ -295,7 +295,10 @@ class DrawerSendExtendedAssert {
   }
 
   async assertReviewTransactionButtonIsEnabled(shouldBeEnabled: boolean) {
-    await new TransactionNewPage().reviewTransactionButton.waitForClickable({ reverse: !shouldBeEnabled });
+    await new TransactionNewPage().reviewTransactionButton.waitForClickable({
+      reverse: !shouldBeEnabled,
+      timeout: 10_000
+    });
   }
 
   async assertReviewTransactionButtonIsDisplayed(shouldBeDisplayed: boolean) {

packages/e2e-tests/src/assert/tokensPageAssert.ts

@@ -152,7 +152,7 @@ class TokensPageAssert {
         (await TokensPage.getTokenBalanceAsFloatByName(tokenName)) === expectedValueRounded - 0.01 ||
         (await TokensPage.getTokenBalanceAsFloatByName(tokenName)) === expectedValueRounded,
       {
-        timeout: 50_000,
+        timeout: 120_000,
         interval: 3000,
         timeoutMsg: `failed while waiting for ${tokenName} value update`
       }

packages/e2e-tests/src/features/analytics/AnalyticsSettingsPopup.feature

@@ -3,6 +3,7 @@ Feature: Analytics - Settings - Popup View
 
   Background:
     Given Lace is ready for test
+    And I de-authorize all DApps in popup mode
 
   @LW-8560
   Scenario: Analytics - Popup view - Settings - Network events - Switch network

packages/e2e-tests/src/features/e2e/SendTransactionDappE2E.feature

@@ -32,7 +32,7 @@ Feature: Send Transactions from Dapp - E2E
     And I click on a transaction: 1
     Then The Tx details are displayed as "package.core.activityDetails.received" for ADA with value: 3.00 and wallet: "WalletSendSimpleTransactionE2E" address
 
-  @LW-6797 @Testnet
+  @LW-6797 @Testnet @wip
   Scenario: Send Token from DApp E2E
     And I save token: "LaceCoin2" balance
     And I open and authorize test DApp with "Only once" setting

packages/e2e-tests/src/pageobject/dAppConnectorPageObject.ts

@@ -11,6 +11,9 @@ import RemoveDAppModal from '../elements/dappConnector/removeDAppModal';
 import testContext from '../utils/testContext';
 import ConfirmTransactionPage from '../elements/dappConnector/confirmTransactionPage';
 import NoWalletModal from '../elements/dappConnector/noWalletModal';
+import DAppConnectorAssert, { ExpectedDAppDetails } from '../assert/dAppConnectorAssert';
+import { Logger } from '../support/logger';
+import TestDAppPage from '../elements/dappConnector/testDAppPage';
 
 class DAppConnectorPageObject {
   TEST_DAPP_URL = this.getTestDAppUrl();
@@ -32,6 +35,12 @@ class DAppConnectorPageObject {
     await browser.switchWindow(this.DAPP_CONNECTOR_WINDOW_HANDLE);
   }
 
+  async closeDappConnectorWindowHandle() {
+    await browser.switchWindow(this.DAPP_CONNECTOR_WINDOW_HANDLE);
+    await browser.closeWindow();
+    await this.switchToTestDAppWindow();
+  }
+
   async switchToTestDAppWindow() {
     await browser.switchWindow(this.TEST_DAPP_NAME);
   }
@@ -91,6 +100,30 @@ class DAppConnectorPageObject {
     feeValue = feeValue.replace(' ADA', '').replace('Fee: ', '');
     await testContext.save('feeValueDAppTx', feeValue);
   }
+
+  async switchToDappConnectorPopupAndAuthorize(testDAppDetails: ExpectedDAppDetails, mode: 'Always' | 'Only once') {
+    await this.waitAndSwitchToDAppConnectorWindow(3);
+    await DAppConnectorAssert.assertSeeAuthorizeDAppPage(testDAppDetails);
+    await this.clickButtonInDAppAuthorizationWindow('Authorize');
+    await this.clickButtonInDAppAuthorizationModal(mode);
+    await this.switchToTestDAppWindow();
+    await DAppConnectorAssert.waitUntilBalanceNotEmpty();
+  }
+  async switchToDappConnectorPopupAndAuthorizeWithRetry(
+    testDAppDetails: ExpectedDAppDetails,
+    mode: 'Always' | 'Only once'
+  ) {
+    try {
+      await this.switchToDappConnectorPopupAndAuthorize(testDAppDetails, mode);
+    } catch {
+      Logger.log('Failed to authorize Dapp. Retry will be executed');
+      if ((await browser.getWindowHandles()).length === 3) {
+        await this.closeDappConnectorWindowHandle();
+      }
+      await TestDAppPage.refreshButton.click();
+      await this.switchToDappConnectorPopupAndAuthorize(testDAppDetails, mode);
+    }
+  }
 }
 
 export default new DAppConnectorPageObject();

packages/e2e-tests/src/steps/dAppConnectorSteps.ts

@@ -171,12 +171,7 @@ Then(/^I see test DApp on the Authorized DApps list$/, async () => {
 
 When(/^I open and authorize test DApp with "(Always|Only once)" setting$/, async (mode: 'Always' | 'Only once') => {
   await DAppConnectorPageObject.openTestDApp();
-  await DAppConnectorPageObject.waitAndSwitchToDAppConnectorWindow(3);
-  await DAppConnectorAssert.assertSeeAuthorizeDAppPage(testDAppDetails);
-  await DAppConnectorPageObject.clickButtonInDAppAuthorizationWindow('Authorize');
-  await DAppConnectorPageObject.clickButtonInDAppAuthorizationModal(mode);
-  await DAppConnectorPageObject.switchToTestDAppWindow();
-  await DAppConnectorAssert.waitUntilBalanceNotEmpty();
+  await DAppConnectorPageObject.switchToDappConnectorPopupAndAuthorizeWithRetry(testDAppDetails, mode);
 });
 
 Then(/^I de-authorize all DApps in (extended|popup) mode$/, async (mode: 'extended' | 'popup') => {
@@ -214,7 +209,7 @@ Then(/^I click "(Send ADA|Send Token)" "Run" button in test DApp$/, async (runBu
       }
       await browser.waitUntil(async () => (await browser.getWindowHandles()).length === handlesBeforeClick + 1, {
         interval: 1000,
-        timeout: 4000,
+        timeout: 6000,
         timeoutMsg: `failed while waiting for ${handlesBeforeClick + 1} window handles`
       });
       break;