Remove bugged or too restrictive WP rules

Author: gmazzap

Inpsyde/Sniffs/CodeQuality/VariablesNameSniff.php

@@ -92,7 +92,8 @@ public function process(File $phpcsFile, $stackPtr)
         $ignored = $this->allIgnored();
         $name = $phpcsFile->getTokens()[$stackPtr]['content'];
 
-        if (in_array($name, $ignored, true)
+        if (
+            in_array($name, $ignored, true)
             || strpos($name, '$wp_') === 0
             || strpos($name, '$_wp_') === 0
         ) {
@@ -108,7 +109,8 @@ public function process(File $phpcsFile, $stackPtr)
 
         $isProperty = PhpcsHelpers::variableIsProperty($phpcsFile, $stackPtr);
 
-        if (($isProperty && $this->arePropertiesIgnored())
+        if (
+            ($isProperty && $this->arePropertiesIgnored())
             || (!$isProperty && $this->areVariablesIgnored())
         ) {
             return;

Inpsyde/ruleset.xml

@@ -53,7 +53,6 @@
     <rule ref="WordPress.DB.RestrictedClasses"/>
     <rule ref="WordPress.DB.RestrictedFunctions"/>
     <rule ref="WordPress.DateTime.CurrentTimeTimestamp"/>
-    <rule ref="WordPress.DateTime.RestrictedFunctions"/>
     <rule ref="WordPress.NamingConventions.PrefixAllGlobals"/>
     <rule ref="WordPress.NamingConventions.ValidHookName">
         <properties>
@@ -71,9 +70,7 @@
     <rule ref="WordPress.PHP.RestrictedPHPFunctions"/>
     <rule ref="WordPress.PHP.DiscouragedPHPFunctions">
         <properties>
-            <property name="exclude" value="serialize"/>
-            <property name="exclude" value="urlencode"/>
-            <property name="exclude" value="obfuscation"/>
+            <property name="exclude" type="array" value="serialize,urlencode,obfuscation"/>
         </properties>
     </rule>
     <rule ref="WordPress.PHP.DiscouragedPHPFunctions.runtime_configuration">
@@ -108,9 +105,7 @@
     <rule ref="WordPress.WP.DiscouragedFunctions"/>
     <rule ref="WordPress.WP.EnqueuedResourceParameters"/>
     <rule ref="WordPress.WP.EnqueuedResources"/>
-    <rule ref="WordPress.WP.GlobalVariablesOverride"/>
     <rule ref="WordPress.WP.I18n"/>
-    <rule ref="WordPress.WhiteSpace.CastStructureSpacing"/>
 
     <!--
     Curated list of WordPress VIP rules.
@@ -123,7 +118,6 @@
     <rule ref="WordPressVIPMinimum.Functions.DynamicCalls"/>
     <rule ref="WordPressVIPMinimum.Hooks.AlwaysReturnInFilter"/>
     <rule ref="WordPressVIPMinimum.Hooks.PreGetPosts"/>
-    <rule ref="WordPressVIPMinimum.Performance.OrderByRand"/>
     <rule ref="WordPressVIPMinimum.Performance.RegexpCompare"/>
     <rule ref="WordPressVIPMinimum.Performance.TaxonomyMetaInOptions"/>
     <rule ref="WordPressVIPMinimum.Security.EscapingVoidReturnFunctions"/>

phpcs.xml

@@ -2,7 +2,9 @@
 <ruleset name="Inpsyde Coding Standard">
 
     <description>PHP 7+ coding standards for Inpsyde WordPress projects.</description>
+
     <autoload>./Inpsyde/PhpcsHelpers.php</autoload>
+    
     <file>./Inpsyde/Sniffs</file>
     <file>./tests/src</file>
     <file>./tests/cases</file>
@@ -66,7 +68,6 @@
     <rule ref="WordPress.DB.RestrictedClasses"/>
     <rule ref="WordPress.DB.RestrictedFunctions"/>
     <rule ref="WordPress.DateTime.CurrentTimeTimestamp"/>
-    <rule ref="WordPress.DateTime.RestrictedFunctions"/>
     <rule ref="WordPress.NamingConventions.PrefixAllGlobals"/>
     <rule ref="WordPress.NamingConventions.ValidHookName">
         <properties>
@@ -84,9 +85,7 @@
     <rule ref="WordPress.PHP.RestrictedPHPFunctions"/>
     <rule ref="WordPress.PHP.DiscouragedPHPFunctions">
         <properties>
-            <property name="exclude" value="serialize"/>
-            <property name="exclude" value="urlencode"/>
-            <property name="exclude" value="obfuscation"/>
+            <property name="exclude" type="array" value="serialize,urlencode,obfuscation"/>
         </properties>
     </rule>
     <rule ref="WordPress.PHP.DiscouragedPHPFunctions.runtime_configuration">
@@ -121,9 +120,7 @@
     <rule ref="WordPress.WP.DiscouragedFunctions"/>
     <rule ref="WordPress.WP.EnqueuedResourceParameters"/>
     <rule ref="WordPress.WP.EnqueuedResources"/>
-    <rule ref="WordPress.WP.GlobalVariablesOverride"/>
     <rule ref="WordPress.WP.I18n"/>
-    <rule ref="WordPress.WhiteSpace.CastStructureSpacing"/>
 
     <!--
     Curated list of WordPress VIP rules.
@@ -136,7 +133,6 @@
     <rule ref="WordPressVIPMinimum.Functions.DynamicCalls"/>
     <rule ref="WordPressVIPMinimum.Hooks.AlwaysReturnInFilter"/>
     <rule ref="WordPressVIPMinimum.Hooks.PreGetPosts"/>
-    <rule ref="WordPressVIPMinimum.Performance.OrderByRand"/>
     <rule ref="WordPressVIPMinimum.Performance.RegexpCompare"/>
     <rule ref="WordPressVIPMinimum.Performance.TaxonomyMetaInOptions"/>
     <rule ref="WordPressVIPMinimum.Security.EscapingVoidReturnFunctions"/>

tests/src/FixtureContentParser.php

@@ -93,7 +93,8 @@ private function processResults(\stdClass $accumulator, string $fixturePath): ar
         $results = $cb(...$results);
         // phpcs:enable
 
-        if ($accumulator->process->content
+        if (
+            $accumulator->process->content
             && !is_array($results)
             || count($results) !== 5
             || !is_string($results[0] ?? null)
@@ -167,7 +168,8 @@ private function readFile(string $file)
      */
     private function readLine(int $lineNum, string $line, \stdClass $accumulator)
     {
-        if (!$this->readProcessLine($lineNum, $line, $accumulator)
+        if (
+            !$this->readProcessLine($lineNum, $line, $accumulator)
             && !$this->readSniffLine($line, $accumulator)
             && !$this->readPropertiesLine($lineNum, $line, $accumulator)
         ) {