Allow few core names in NoAccessorsSniff

Author: gmazzap

Inpsyde/Sniffs/CodeQuality/NoAccessorsSniff.php

@@ -25,7 +25,12 @@
  */
 final class NoAccessorsSniff implements Sniff
 {
-    public $allowSetUp = true;
+    const ALLOWED_NAMES = [
+        'getIterator',
+        'getInnerIterator',
+        'getChildren',
+        'setUp',
+    ];
 
     public $skipForFunctions = true;
 
@@ -50,7 +55,7 @@ public function process(File $file, $position)
 
         $functionName = $file->getDeclarationName($position);
 
-        if (!$functionName || ($functionName === 'setUp' && $this->allowSetUp)) {
+        if (!$functionName || in_array($functionName, self::ALLOWED_NAMES, true)) {
             return;
         }
 

tests/fixtures/no-accessors.php

@@ -21,7 +21,7 @@ function setTheThing($foo, $bar);
     function setting();
 }
 
-class WithAccessors {
+class WithAccessors implements \IteratorAggregate {
 
     function thing() {
 
@@ -44,4 +44,12 @@ function withThing() {
     function setTheThing($foo, $bar) {
 
     }
+
+    /**
+     * @inheritdoc
+     */
+    public function getIterator()
+    {
+        return new \ArrayIterator();
+    }
 }