Fix serve ID not considered for in-band syncs (#848)

Author: amh4r

.changeset/lovely-oranges-return.md

@@ -0,0 +1,5 @@
+---
+"inngest": patch
+---
+
+Fix serve ID not considered for in-band syncs

packages/inngest/src/components/InngestCommHandler.ts

@@ -366,6 +366,12 @@ export class InngestCommHandler<
 
     this.frameworkName = options.frameworkName;
     this.client = options.client as Inngest.Any;
+
+    if (options.id) {
+      console.warn(
+        `${logPrefix} The \`id\` serve option is deprecated and will be removed in v4`
+      );
+    }
     this.id = options.id || this.client.id;
 
     this.handler = options.handler as Handler;
@@ -1627,7 +1633,7 @@ export class InngestCommHandler<
     });
 
     const body: InBandRegisterRequest = {
-      app_id: this.client.id,
+      app_id: this.id,
       appVersion: this.client.appVersion,
       capabilities: registerBody.capabilities,
       env,
@@ -1700,7 +1706,7 @@ export class InngestCommHandler<
           ...introspection,
           authentication_succeeded: true,
           api_origin: this.apiBaseUrl,
-          app_id: this.client.id,
+          app_id: this.id,
           capabilities: {
             trust_probe: "v1",
             connect: "v1",

packages/inngest/src/types.ts

@@ -850,6 +850,7 @@ export interface RegisterOptions {
   /**
    * The ID of this app. This is used to group functions together in the Inngest
    * UI. The ID of the passed client is used by default.
+   * @deprecated Will be removed in v4.
    */
   id?: string;
 }