fix: build with warnings as errors

Author: InfiniteTabs

.github/workflows/tests.yaml

@@ -12,6 +12,23 @@ permissions:
   contents: read
 
 jobs:
+  build:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v4
+
+      - name: Set up Rust toolchain
+        uses: actions-rs/toolchain@v1
+        with:
+          toolchain: stable
+          override: true
+
+      - name: Build with warnings as errors
+        run: cargo build --all-targets
+        env:
+          RUSTFLAGS: "-D warnings"
+
   lint:
     runs-on: ubuntu-latest
     steps:

Makefile

@@ -3,7 +3,11 @@
 build-operator:
 	DOCKER_BUILDKIT=1 docker build -t infraweave-operator -f operator/Dockerfile .
 
-unit-tests:
+build-check:
+	@echo "Building with warnings as errors..."
+	RUSTFLAGS="-D warnings" cargo build --all-targets
+
+unit-tests: build-check
 	cargo test --workspace --exclude integration-tests
 
 integration-tests: aws-integration-tests azure-integration-tests

defs/src/gitprovider.rs

@@ -98,9 +98,6 @@ pub enum ExtraData {
     None,
 }
 
-#[derive(Serialize, Deserialize, Clone, Debug)]
-pub struct None {}
-
 #[derive(Serialize, Deserialize, Clone, Debug)]
 pub struct GitLabCheckRun {
     pub project: GitLabProject,

defs/src/hcl.rs

@@ -4,7 +4,6 @@ mod environment;
 mod errors;
 mod event;
 mod gitprovider;
-mod hcl;
 mod infra;
 mod infra_change_record;
 mod log;

defs/src/lib.rs

@@ -213,11 +213,3 @@ pub struct Metadata {
     pub name: String,
     // pub group: String,
 }
-
-#[derive(Debug, Serialize, Deserialize, Clone)]
-pub struct Output {
-    // This struct is added to match the outputs array
-    pub name: String,
-    // #[serde(rename = "type")]
-    // pub type_: String,
-}

defs/src/module.rs

@@ -16,6 +16,7 @@ use crate::validation::validate_claim;
 /// Kubernetes AdmissionReview request structure
 #[derive(Debug, Deserialize)]
 #[serde(rename_all = "camelCase")]
+#[allow(dead_code)]
 pub struct AdmissionReview {
     pub api_version: String,
     pub kind: String,
@@ -24,6 +25,7 @@ pub struct AdmissionReview {
 
 #[derive(Debug, Deserialize)]
 #[serde(rename_all = "camelCase")]
+#[allow(dead_code)]
 pub struct AdmissionRequest {
     pub uid: String,
     pub kind: GroupVersionKind,
@@ -34,6 +36,7 @@ pub struct AdmissionRequest {
 
 #[derive(Debug, Deserialize)]
 #[serde(rename_all = "camelCase")]
+#[allow(dead_code)]
 pub struct GroupVersionKind {
     pub group: String,
     pub version: String,
@@ -42,6 +45,7 @@ pub struct GroupVersionKind {
 
 #[derive(Debug, Deserialize)]
 #[serde(rename_all = "camelCase")]
+#[allow(dead_code)]
 pub struct GroupVersionResource {
     pub group: String,
     pub version: String,

operator/src/webhook.rs

@@ -357,7 +357,7 @@ async fn get_current_job_id(
 fn initiate_deployment_status_handler(
     initial_deployment: Option<DeploymentResp>,
     payload_with_variables: &ApiInfraPayloadWithVariables,
-) -> DeploymentStatusHandler {
+) -> DeploymentStatusHandler<'_> {
     let payload = &payload_with_variables.payload;
     let command = &payload.command;
     let environment = &payload.environment;