refactor: remove redundant variables

Author: rohit-ng

README.md

@@ -116,8 +116,6 @@ This command will display the values of the stored parameters, ensuring they hav
 | <a name="input_deletion_protection"></a> [deletion\_protection](#input\_deletion\_protection) | Whether to enable deletion protection | `bool` | `false` | no |
 | <a name="input_desired_capacity"></a> [desired\_capacity](#input\_desired\_capacity) | Desired capacity of auto scaling group | `number` | `2` | no |
 | <a name="input_desired_count_for_kong_service"></a> [desired\_count\_for\_kong\_service](#input\_desired\_count\_for\_kong\_service) | Desired count for kong service | `number` | `1` | no |
-| <a name="input_ecs_node_security_group_id"></a> [ecs\_node\_security\_group\_id](#input\_ecs\_node\_security\_group\_id) | ECS node security group id | `string` | `null` | no |
-| <a name="input_ecs_task_security_group_id"></a> [ecs\_task\_security\_group\_id](#input\_ecs\_task\_security\_group\_id) | ECS task security group id | `string` | `null` | no |
 | <a name="input_force_new_deployment"></a> [force\_new\_deployment](#input\_force\_new\_deployment) | Whether to force new deployment | `bool` | `true` | no |
 | <a name="input_instance_type_for_kong"></a> [instance\_type\_for\_kong](#input\_instance\_type\_for\_kong) | Instance type for kong | `string` | `"t2.micro"` | no |
 | <a name="input_key_name_for_kong"></a> [key\_name\_for\_kong](#input\_key\_name\_for\_kong) | Key name for to SSH into kong instance | `string` | `null` | no |
@@ -142,8 +140,6 @@ This command will display the values of the stored parameters, ensuring they hav
 | <a name="input_rds_instance_class"></a> [rds\_instance\_class](#input\_rds\_instance\_class) | The instance class to use | `string` | `"db.t3.micro"` | no |
 | <a name="input_ssl_policy"></a> [ssl\_policy](#input\_ssl\_policy) | (Optional) Name of the SSL Policy for the listener. | `string` | `"ELBSecurityPolicy-2016-08"` | no |
 | <a name="input_target_capacity"></a> [target\_capacity](#input\_target\_capacity) | Target Capacity for managed scaling | `number` | `100` | no |
-| <a name="input_use_default_ecs_node_security_group"></a> [use\_default\_ecs\_node\_security\_group](#input\_use\_default\_ecs\_node\_security\_group) | Whether to use default ECS node security group | `bool` | `true` | no |
-| <a name="input_use_default_ecs_task_security_group"></a> [use\_default\_ecs\_task\_security\_group](#input\_use\_default\_ecs\_task\_security\_group) | Whether to use default ECS task security group | `bool` | `true` | no |
 | <a name="input_vpc_id"></a> [vpc\_id](#input\_vpc\_id) | The ID of the VPC | `string` | n/a | yes |
 
 ## Outputs

main.tf

@@ -204,7 +204,7 @@ module "ecs_kong" {
     ]
     network_configuration = {
       subnets          = var.private_subnet_ids
-      security_groups  = [var.use_default_ecs_task_security_group ? module.ecs_task_security_group.security_group_id : var.ecs_task_security_group_id]
+      security_groups  = [module.ecs_task_security_group.security_group_id]
       assign_public_ip = false
     }
   }
@@ -247,7 +247,7 @@ module "ecs_kong" {
       name                   = local.kong.launch_template_name
       image_id               = local.kong.image_id
       instance_type          = var.instance_type_for_kong
-      vpc_security_group_ids = [var.use_default_ecs_node_security_group ? module.ecs_node_security_group.security_group_id : var.ecs_node_security_group_id]
+      vpc_security_group_ids = [module.ecs_node_security_group.security_group_id]
       key_name               = var.key_name_for_kong
       user_data              = local.ecs.user_data
     }

variables.tf

@@ -141,30 +141,6 @@ variable "target_capacity" {
   default     = 100
 }
 
-variable "use_default_ecs_node_security_group" {
-  description = "Whether to use default ECS node security group"
-  type        = bool
-  default     = true
-}
-
-variable "ecs_node_security_group_id" {
-  description = "ECS node security group id"
-  type        = string
-  default     = null
-}
-
-variable "use_default_ecs_task_security_group" {
-  description = "Whether to use default ECS task security group"
-  type        = bool
-  default     = true
-}
-
-variable "ecs_task_security_group_id" {
-  description = "ECS task security group id"
-  type        = string
-  default     = null
-}
-
 variable "desired_capacity" {
   description = "Desired capacity of auto scaling group"
   type        = number