refactor: add Connection::zero()

Author: catconcat

ibc-core/ics03-connection/types/src/events.rs

@@ -323,7 +323,7 @@ mod tests {
 
         let client_type = ClientType::from_str("07-tendermint")
             .expect("never fails because it's a valid client type");
-        let conn_id_on_a = ConnectionId::new(0);
+        let conn_id_on_a = ConnectionId::zero();
         let client_id_on_a = client_type.build_client_id(0);
         let conn_id_on_b = ConnectionId::new(1);
         let client_id_on_b = client_type.build_client_id(1);

ibc-core/ics04-channel/types/src/events/mod.rs

@@ -1133,7 +1133,7 @@ mod tests {
 
         let port_id = PortId::transfer();
         let channel_id = ChannelId::zero();
-        let connection_id = ConnectionId::new(0);
+        let connection_id = ConnectionId::zero();
         let counterparty_port_id = PortId::transfer();
         let counterparty_channel_id = ChannelId::new(1);
         let version = Version::new("ics20-1".to_string());

ibc-core/ics24-host/types/src/identifiers/connection_id.rs

@@ -56,6 +56,11 @@ impl ConnectionId {
     pub fn as_bytes(&self) -> &[u8] {
         self.0.as_bytes()
     }
+
+    /// Return ConnectionId with identifier 0
+    pub fn zero() -> Self {
+        Self::new(0)
+    }
 }
 
 /// This implementation provides a `to_string` method.

ibc-core/ics24-host/types/src/path.rs

@@ -1214,7 +1214,7 @@ mod tests {
     )]
     #[case(
         "connections/connection-0",
-        Path::Connection(ConnectionPath(ConnectionId::new(0)))
+        Path::Connection(ConnectionPath(ConnectionId::zero()))
     )]
     #[case("ports/transfer", Path::Ports(PortPath(PortId::transfer())))]
     #[case(
@@ -1340,7 +1340,7 @@ mod tests {
 
         assert_eq!(
             parse_connections(&components),
-            Some(Path::Connection(ConnectionPath(ConnectionId::new(0)))),
+            Some(Path::Connection(ConnectionPath(ConnectionId::zero()))),
         );
     }
 

ibc-testkit/src/fixtures/core/channel/mod.rs

@@ -46,7 +46,7 @@ pub fn dummy_raw_channel_end(state: i32, channel_id: Option<u64>) -> RawChannel
         state,
         ordering: 2,
         counterparty: Some(dummy_raw_counterparty_chan(channel_id)),
-        connection_hops: vec![ConnectionId::new(0).to_string()],
+        connection_hops: vec![ConnectionId::zero().to_string()],
         version: "".to_string(), // The version is not validated.
     }
 }

ibc-testkit/src/fixtures/core/channel/packet.rs

@@ -267,7 +267,7 @@ mod tests {
         let ibc_event = IbcEvent::SendPacket(SendPacket::new(
             packet,
             Order::Unordered,
-            ConnectionId::new(0),
+            ConnectionId::zero(),
         ));
         let _ = tendermint::abci::Event::try_from(ibc_event);
     }

ibc-testkit/src/fixtures/core/connection/conn_open_ack.rs

@@ -24,7 +24,7 @@ pub fn dummy_raw_msg_conn_open_ack(
 ) -> RawMsgConnectionOpenAck {
     let client_state_height = Height::new(0, consensus_height).expect("invalid height");
     RawMsgConnectionOpenAck {
-        connection_id: ConnectionId::new(0).to_string(),
+        connection_id: ConnectionId::zero().to_string(),
         counterparty_connection_id: ConnectionId::new(1).to_string(),
         proof_try: dummy_proof(),
         proof_height: Some(RawHeight {

ibc-testkit/src/fixtures/core/connection/conn_open_try.rs

@@ -41,7 +41,7 @@ pub fn dummy_raw_msg_conn_open_try(
     #[allow(deprecated)]
     RawMsgConnectionOpenTry {
         client_id: ClientId::from("07-tendermint-0").to_string(),
-        previous_connection_id: ConnectionId::new(0).to_string(),
+        previous_connection_id: ConnectionId::zero().to_string(),
         client_state: Some(MockClientState::new(MockHeader::new(client_state_height)).into()),
         counterparty: Some(dummy_raw_counterparty_conn(Some(0))),
         delay_period: 0,

ibc-testkit/tests/core/ics04_channel/acknowledgement.rs

@@ -60,7 +60,7 @@ fn fixture() -> Fixture {
         State::Open,
         Order::Unordered,
         Counterparty::new(packet.port_id_on_b, Some(packet.chan_id_on_b)),
-        vec![ConnectionId::new(0)],
+        vec![ConnectionId::zero()],
         Version::new("ics20-1".to_string()),
     )
     .unwrap();
@@ -73,7 +73,7 @@ fn fixture() -> Fixture {
         ClientId::from("07-tendermint-0"),
         ConnectionCounterparty::new(
             ClientId::from("07-tendermint-0"),
-            Some(ConnectionId::new(0)),
+            Some(ConnectionId::zero()),
             CommitmentPrefix::empty(),
         ),
         get_compatible_versions(),
@@ -132,7 +132,7 @@ fn ack_success_no_packet_commitment(fixture: Fixture) {
             ChannelId::zero(),
             chan_end_on_a_unordered,
         )
-        .with_connection(ConnectionId::new(0), conn_end_on_a);
+        .with_connection(ConnectionId::zero(), conn_end_on_a);
 
     let msg_envelope = MsgEnvelope::from(PacketMsg::from(msg));
 
@@ -167,7 +167,7 @@ fn ack_success_happy_path(fixture: Fixture) {
             ChannelId::zero(),
             chan_end_on_a_unordered,
         )
-        .with_connection(ConnectionId::new(0), conn_end_on_a)
+        .with_connection(ConnectionId::zero(), conn_end_on_a)
         .with_packet_commitment(
             msg.packet.port_id_on_a.clone(),
             msg.packet.chan_id_on_a.clone(),
@@ -210,7 +210,7 @@ fn ack_unordered_chan_execute(fixture: Fixture) {
             ChannelId::zero(),
             chan_end_on_a_unordered,
         )
-        .with_connection(ConnectionId::new(0), conn_end_on_a)
+        .with_connection(ConnectionId::zero(), conn_end_on_a)
         .with_packet_commitment(
             msg.packet.port_id_on_a.clone(),
             msg.packet.chan_id_on_a.clone(),
@@ -247,7 +247,7 @@ fn ack_ordered_chan_execute(fixture: Fixture) {
     } = fixture;
     let mut ctx = ctx
         .with_channel(PortId::transfer(), ChannelId::zero(), chan_end_on_a_ordered)
-        .with_connection(ConnectionId::new(0), conn_end_on_a)
+        .with_connection(ConnectionId::zero(), conn_end_on_a)
         .with_packet_commitment(
             msg.packet.port_id_on_a.clone(),
             msg.packet.chan_id_on_a.clone(),

ibc-testkit/tests/core/ics04_channel/chan_open_init.rs

@@ -52,7 +52,7 @@ fn fixture() -> Fixture {
                 .latest_height(client_height)
                 .build(),
         )
-        .with_connection(ConnectionId::new(0), conn_end_on_a);
+        .with_connection(ConnectionId::zero(), conn_end_on_a);
 
     Fixture { ctx, router, msg }
 }