refactor(ibc-core): remove ProofSpecs::default()

Author: catconcat

ibc-clients/ics07-tendermint/src/client_state.rs

@@ -112,7 +112,7 @@ mod tests {
             unbonding_period: Duration::new(128000, 0),
             max_clock_drift: Duration::new(3, 0),
             latest_height: Height::new(1, 10).expect("Never fails"),
-            proof_specs: ProofSpecs::default(),
+            proof_specs: ProofSpecs::cosmos(),
             upgrade_path: Default::default(),
             allow_update: AllowUpdate {
                 after_expiry: false,

ibc-clients/ics07-tendermint/types/src/client_state.rs

@@ -444,7 +444,7 @@ mod tests {
             unbonding_period: Duration::new(128000, 0),
             max_clock_drift: Duration::new(3, 0),
             latest_height: Height::new(0, 10).expect("Never fails"),
-            proof_specs: ProofSpecs::default(),
+            proof_specs: ProofSpecs::cosmos(),
             upgrade_path: Default::default(),
             allow_update: AllowUpdate {
                 after_expiry: false,

ibc-core/ics23-commitment/types/src/specs.rs

@@ -25,12 +25,6 @@ impl ProofSpecs {
     }
 }
 
-impl Default for ProofSpecs {
-    fn default() -> Self {
-        Self::cosmos()
-    }
-}
-
 impl From<Vec<RawProofSpec>> for ProofSpecs {
     fn from(ics23_specs: Vec<RawProofSpec>) -> Self {
         Self(

ibc-testkit/src/fixtures/core/channel/mod.rs

@@ -46,7 +46,7 @@ pub fn dummy_raw_channel_end(state: i32, channel_id: Option<u64>) -> RawChannel
         state,
         ordering: 2,
         counterparty: Some(dummy_raw_counterparty_chan(channel_id)),
-        connection_hops: vec![ConnectionId::default().to_string()],
+        connection_hops: vec![ConnectionId::new(0).to_string()],
         version: "".to_string(), // The version is not validated.
     }
 }