Not working with Ember 1.13.3

[LexLythius]

Simple modal example doesn't work for me.

Uncaught TypeError: Cannot read property 'modal1' of undefined
(anonymous function) @ modal-toggler.js:49

this line breaks:

return this.set('modal', Em['default'].View.views[this.get('modal-id')]);

So when I click the button, another error is thrown:
Uncaught TypeError: Cannot read property 'toggleVisibility' of undefined.

The problem is that Ember.View.views doesn't exist in this version.
I tried installing ember-legacy-views addon but no luck either.

[tommyblue]

Any feedback on this? This issue is blocking the upgrade of the app... :(

[asaf]

I'm currently busy with other things, a PR will be very appreciated.

[tommyblue]

I never wrote an addon for Ember, but I can try :)
I think, as suggested by @LexLythius that the problem is in modal-toggler.js, line 61:

return this.set('modal', Em.View.views[this.get('modal-id')]);

Now that views are deprecated, which is the correct way to find the modal?

[LexLythius]

I got it working, but I'm not sure in a future-proof way, that's why I didn't place a PR yet.
Check this out: http://discuss.emberjs.com/t/view-views-missing-in-1-13-breaks-bootstrap-modal-plugin/8681
A reply there leads us to http://blog.atmartin.io/a-simple-modal-for-ember-v2-component-edition/ but I didn't have the time yet to do something in that direction. Will do as soon as I can.

[jportner]

Seeing as this hasn't gotten any attention in a couple of months, I went ahead and submitted a PR with the temporary fix. As LexLythius said there is probably a better, more future-proof way to do this.

[asaf]

@jportner Lately I don't have much time for this project, I am looking for a new maintainer, if you guys are willing to continue the development then I'll be gladly to discuss it in more details.