Replies: 2 comments
-
Sure I will do it today. In addition to the name, a similar check for consensus key will be added. |
Beta Was this translation helpful? Give feedback.
0 replies
-
Included in #74 |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
-
Description
I get some thoughts when reviewing the Bootstrap contract and other contracts, so I just share here for discussion with @MaxMustermann2 and other team members
https://github.com/ExocoreNetwork/exocore-contracts/blob/712cfd5d930a55379a77f59ba32a6d0ed8292b05/src/core/Bootstrap.sol#L212-L217
I think we should check that name is not empty string here
https://github.com/ExocoreNetwork/exocore-contracts/blob/712cfd5d930a55379a77f59ba32a6d0ed8292b05/src/core/Bootstrap.sol#L281-L291
iteration over
registeredValidators
is expensive, so maybe we should add a new state variablemapping(string => bool) public nameUsed
to determine whether a name has been used. this is also mentioned in #18@MaxMustermann2 what do you think?
Beta Was this translation helpful? Give feedback.
All reactions