[import/order] Breaking change in v2.27

[StefanoMagrassi]

In version 2.27.0 it was introduced a new strategy which splits the imports paths in segments and compares them independently.

However, this leads to different results for the same inputs in some cases, for example:

import {screen} from '@testing-library/react';
import {checkDropdown} from '@testing/form';

this is the "right" order as by v2.26 because:

compareString('@testing-library/react', '@testing/form') === -1

but in v2.27 it is reported as error because:

compareString('@testing-library', '@testing') === 1

I don't know if the current behavior is the right one, but it is definitely a breaking change

[ljharb]

I agree that it was an unintentional change, and also that the one that’s right in 2.26 is the right one. (i think the change you’re referencing was #2396)

[StefanoMagrassi]

(i think the change you’re referencing was #2396)

yep

[7iomka]

Any news on this?

[ljharb]

No, not yet, but it'd be great to get a PR up to fix it.

[7iomka]

No, not yet, but it'd be great to get a PR up to fix it.

Just revert #2396

[ljharb]

@7iomka it may not be that simple; there may be some fixes in it that we'd need to keep.

[DaveTryon]

This is still broken in 2.28. We're hitting it in microsoft/accessibility-insights-web#6846. git bisect confirms that it broke in #2396

Here's a quick unit test to use as a reference:

    // Option alphabetize: {order: 'asc'} when folders and paths start with the same substring
    test({
      code: `
        import a from "foo/foobar-file";
        import b from "foo/foobar/file";
      `,
      options: [{ alphabetize: { order: 'asc' } }],
    }),

[tw3]

Any plans to fix this in the future? Or make it configurable?

The main frustration is the new import sort no longer matches "Organize Imports" in WebStorm.

"Organize Imports" in WebStorm still sorts as:

import {screen} from '@testing-library/react';
import {checkDropdown} from '@testing/form';

while the latest import/order lint fix sorts that as:

import {checkDropdown} from '@testing/form';
import {screen} from '@testing-library/react';

[tw3]

PR: #3196