Merge branch 'main' into pr/extensions-checkTypeImports

Author: phryneas

CHANGELOG.md

@@ -17,6 +17,9 @@ This change log adheres to standards from [Keep a CHANGELOG](https://keepachange
 - [Docs] [`no-duplicates`]: fix example schema ([#2684], thanks [@simmo])
 - [Docs] [`group-exports`]: fix syntax highlighting ([#2699], thanks [@devinrhode2])
 - [Docs] [`extensions`]: reference node ESM behavior ([#2748], thanks [@xM8WVqaG])
+- [Refactor] [`exports-last`]: use `array.prototype.findlastindex` (thanks [@ljharb])
+- [Refactor] [`no-anonymous-default-export`]: use `object.fromentries` (thanks [@ljharb])
+- [Refactor] [`no-unused-modules`]: use `array.prototype.flatmap` (thanks [@ljharb])
 
 ## [2.27.5] - 2023-01-16
 

package.json

@@ -42,6 +42,7 @@
   "keywords": [
     "eslint",
     "eslintplugin",
+    "eslint-plugin",
     "es6",
     "jsnext",
     "modules",
@@ -101,6 +102,7 @@
   },
   "dependencies": {
     "array-includes": "^3.1.6",
+    "array.prototype.findlastindex": "^1.2.2",
     "array.prototype.flat": "^1.3.1",
     "array.prototype.flatmap": "^1.3.1",
     "debug": "^3.2.7",
@@ -111,6 +113,7 @@
     "is-core-module": "^2.12.1",
     "is-glob": "^4.0.3",
     "minimatch": "^3.1.2",
+    "object.fromentries": "^2.0.6",
     "object.values": "^1.1.6",
     "resolve": "^1.22.3",
     "semver": "^6.3.0",

src/rules/exports-last.js

@@ -1,3 +1,5 @@
+import findLastIndex from 'array.prototype.findlastindex';
+
 import docsUrl from '../docsUrl';
 
 function isNonExportStatement({ type }) {
@@ -20,15 +22,10 @@ module.exports = {
   create(context) {
     return {
       Program({ body }) {
-        const lastNonExportStatementIndex = body.reduce(function findLastIndex(acc, item, index) {
-          if (isNonExportStatement(item)) {
-            return index;
-          }
-          return acc;
-        }, -1);
+        const lastNonExportStatementIndex = findLastIndex(body, isNonExportStatement);
 
         if (lastNonExportStatementIndex !== -1) {
-          body.slice(0, lastNonExportStatementIndex).forEach(function checkNonExport(node) {
+          body.slice(0, lastNonExportStatementIndex).forEach((node) => {
             if (!isNonExportStatement(node)) {
               context.report({
                 node,

src/rules/no-anonymous-default-export.js

@@ -3,8 +3,11 @@
  * @author Duncan Beevers
  */
 
-import docsUrl from '../docsUrl';
 import has from 'has';
+import values from 'object.values';
+import fromEntries from 'object.fromentries';
+
+import docsUrl from '../docsUrl';
 
 const defs = {
   ArrayExpression: {
@@ -68,12 +71,7 @@ const schemaProperties = Object.keys(defs)
     return acc;
   }, {});
 
-const defaults = Object.keys(defs)
-  .map((key) => defs[key])
-  .reduce((acc, def) => {
-    acc[def.option] = has(def, 'default') ? def.default : false;
-    return acc;
-  }, {});
+const defaults = fromEntries(values(defs).map((def) => [def.option, has(def, 'default') ? def.default : false]));
 
 module.exports = {
   meta: {

src/rules/no-unused-modules.js

@@ -4,15 +4,17 @@
  * @author René Fermann
  */
 
-import Exports, { recursivePatternCapture } from '../ExportMap';
 import { getFileExtensions } from 'eslint-module-utils/ignore';
 import resolve from 'eslint-module-utils/resolve';
 import visit from 'eslint-module-utils/visit';
-import docsUrl from '../docsUrl';
 import { dirname, join } from 'path';
 import readPkgUp from 'eslint-module-utils/readPkgUp';
 import values from 'object.values';
 import includes from 'array-includes';
+import flatMap from 'array.prototype.flatmap';
+
+import Exports, { recursivePatternCapture } from '../ExportMap';
+import docsUrl from '../docsUrl';
 
 let FileEnumerator;
 let listFilesToProcess;
@@ -40,12 +42,7 @@ try {
       const { listFilesToProcess: originalListFilesToProcess } = require('eslint/lib/util/glob-util');
 
       listFilesToProcess = function (src, extensions) {
-        const patterns = src.reduce(
-          (carry, pattern) => carry.concat(
-            extensions.map((extension) => (/\*\*|\*\./).test(pattern) ? pattern : `${pattern}/**/*${extension}`),
-          ),
-          src,
-        );
+        const patterns = src.concat(flatMap(src, (pattern) => extensions.map((extension) => (/\*\*|\*\./).test(pattern) ? pattern : `${pattern}/**/*${extension}`)));
 
         return originalListFilesToProcess(patterns);
       };
@@ -171,18 +168,17 @@ const isNodeModule = (path) => (/\/(node_modules)\//).test(path);
 const resolveFiles = (src, ignoreExports, context) => {
   const extensions = Array.from(getFileExtensions(context.settings));
 
-  const srcFiles = new Set();
   const srcFileList = listFilesToProcess(src, extensions);
 
   // prepare list of ignored files
-  const ignoredFilesList =  listFilesToProcess(ignoreExports, extensions);
+  const ignoredFilesList = listFilesToProcess(ignoreExports, extensions);
   ignoredFilesList.forEach(({ filename }) => ignoredFiles.add(filename));
 
   // prepare list of source files, don't consider files from node_modules
-  srcFileList.filter(({ filename }) => !isNodeModule(filename)).forEach(({ filename }) => {
-    srcFiles.add(filename);
-  });
-  return srcFiles;
+
+  return new Set(
+    srcFileList.filter(({ filename }) => !isNodeModule(filename)).map(({ filename }) => filename),
+  );
 };
 
 /**