Skip to content

Problems with the new judge_score implementation #159

@nntoan209

Description

@nntoan209
  • Judge score uses StreamedSyntheticPartialDataset, which cuts off the messages randomly, so the last 'role' of the conversation to generate from can be both user and assistant:
allowed_len = min(len(messages), self.max_messages)
if random.random() < self._cut_message_chain_early:
    # Choose a random cutoff between at least half of allowed_len and allowed_len
    min_cut = max(1, allowed_len // 2)
    cutoff = random.randint(min_cut, allowed_len)
else:
    cutoff = allowed_len
truncated_messages = messages[:cutoff]
  • The original_conversation is created by appending truncated_messages with the LAST assistant response, not the next assistant response, so the response may be irrelevant to the user message. This doesn't make any sense. For example, if the current user message is "How are you today?", what's the point of generating a better answer than "Alright, see you later!" (the last assistant message)?

Have you guys considered these problems?

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions