[1.x] Improve workflows (#190)

* chore: remove unnecessary files

* chore: update ci workflow

* fix: add missing commands

* chore: update pr template

* fix: add missing extensions

Author: imdhemy

.github/pull_request_template.md

@@ -1,19 +1,17 @@
-| Q             | A                                                                        |
-|---------------|--------------------------------------------------------------------------|
-| Branch?       | master for breaking changes, and `release/y.x` for bc <!-- see below --> |
-| Bug fix?      | yes/no                                                                   |
-| New feature?  | yes/no <!-- please update /CHANGELOG.md files -->                        |
-| Deprecations? | yes/no <!-- please update UPGRADE-*.md and /CHANGELOG.md files -->       |
-| Tickets       | Fix #... <!-- prefix each issue number with "Fix #", -->                 |
-| License       | MIT                                                                      |
+| Q             | A                                                        |
+|---------------|----------------------------------------------------------|
+| Branch?       | 1.x (current) or main (for breaking changes)             |
+| Deprecations? | yes/no <!-- please update UPGRADE-2.md                   |
+| Tickets       | Fix #... <!-- prefix each issue number with "Fix #", --> |
+| License       | MIT                                                      |
 
 <!--
 Replace this notice with a short README for your feature/bugfix.
 This will help reviewers and should be a good start for the documentation.
 
 For bug fixes and new features, that does not break BC, please base your PR 
 on the `release/y.x` branch. For BC breaks, please base your PR on the 
-`master` branch.
+`main` branch.
 
 Always add tests and ensure they pass.
 -->

.github/workflows/ci.yml

@@ -1,114 +1,36 @@
-# https://help.github.com/en/categories/automating-your-workflow-with-github-actions
-
-name: "Continuous Integration"
-
-on:
-  pull_request:
-  push:
-
+name: CI
+on: [ push, pull_request ]
 jobs:
-  phpunit:
-    name: "PHPUnit tests"
-
+  ci:
+    name: "CI"
     runs-on: ${{ matrix.operating-system }}
-
     strategy:
       matrix:
-        dependencies:
-          - "locked"
-        php-version:
-          - "8.0"
-          - "8.1"
-          - "8.2"
-        operating-system:
-          - "ubuntu-latest"
-          - "windows-latest"
-          - "macos-latest"
-
+        operating-system: [ ubuntu-latest, windows-latest, macos-latest ]
+        php-version: [ 8.0, 8.3 ]
     steps:
+
+      # --------- Setup steps ---------
       - name: "Checkout"
-        uses: "actions/checkout@v3"
+        uses: actions/checkout@v3
 
-      - name: "Install PHP"
-        uses: "shivammathur/setup-php@v2"
+      - name: "Setup PHP"
+        uses: shivammathur/setup-php@v2
         with:
           coverage: "pcov"
           php-version: "${{ matrix.php-version }}"
           ini-values: memory_limit=-1
-          extensions: sodium, fileinfo
+          extensions: pcov, xdebug, sodium, fileinfo
 
       - name: "Install dependencies"
-        uses: "ramsey/composer-install@v2"
-        with:
-          dependency-versions: "${{ matrix.dependencies }}"
+        uses: ramsey/composer-install@v2
 
-      - name: "Tests"
+      # --------- Run steps ---------
+      - name: "Unit Tests"
         run: "composer test"
 
-  static-analysis-psalm:
-    name: "Static Analysis by Psalm"
-
-    runs-on: ${{ matrix.operating-system }}
-
-    strategy:
-      matrix:
-        dependencies:
-          - "locked"
-        php-version:
-          - "8.0"
-        operating-system:
-          - "ubuntu-latest"
-
-    steps:
-      - name: "Checkout"
-        uses: "actions/checkout@v3"
-
-      - name: "Install PHP"
-        uses: "shivammathur/setup-php@v2"
-        with:
-          coverage: "none"
-          php-version: "${{ matrix.php-version }}"
-          ini-values: memory_limit=-1
-          extensions: sodium, fileinfo
-
-      - name: "Install dependencies"
-        uses: "ramsey/composer-install@v2"
-        with:
-          dependency-versions: "${{ matrix.dependencies }}"
+      - name: "Coding Style"
+        run: "composer cs-fix"
 
-      - name: "psalm"
+      - name: "Static code analysis"
         run: "composer psalm"
-
-  coding-standards:
-    name: "Check Coding Standards"
-
-    runs-on: ${{ matrix.operating-system }}
-
-    strategy:
-      matrix:
-        dependencies:
-          - "locked"
-        php-version:
-          - "8.0"
-        operating-system:
-          - "ubuntu-latest"
-
-    steps:
-      - name: "Checkout"
-        uses: "actions/checkout@v3"
-
-      - name: "Install PHP"
-        uses: "shivammathur/setup-php@v2"
-        with:
-          coverage: "none"
-          php-version: "${{ matrix.php-version }}"
-          ini-values: memory_limit=-1
-          extensions: sodium, fileinfo
-
-      - name: "Install dependencies"
-        uses: "ramsey/composer-install@v2"
-        with:
-          dependency-versions: "${{ matrix.dependencies }}"
-
-      - name: "Coding Standard"
-        run: "composer check-style"

.github/workflows/close-stales.yml

@@ -35,13 +35,13 @@
     }
   },
   "scripts": {
-    "psalm": "vendor/bin/psalm",
     "psalm-info": "vendor/bin/psalm --show-info=true",
-    "format": "vendor/bin/php-cs-fixer fix --allow-risky=yes",
-    "check-style": "vendor/bin/php-cs-fixer fix --dry-run",
     "test": "vendor/bin/phpunit --testdox",
     "keygen": "sh ./bin/keygen.sh",
     "security-advice": "composer update --dry-run roave/security-advisories",
+    "cs-check": "vendor/bin/php-cs-fixer fix --dry-run --diff --verbose",
+    "cs-fix": "php-cs-fixer fix --verbose",
+    "psalm": "psalm --no-cache",
     "post-autoload-dump": [
       "@keygen"
     ]