Skip to content

Commit 20666c4

Browse files
authored
Merge pull request #1 from ika-rwth-aachen/improvement/usability
Improve usability
2 parents ced6f64 + b8186e4 commit 20666c4

File tree

4 files changed

+11
-5
lines changed

4 files changed

+11
-5
lines changed

README.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -63,6 +63,13 @@ pip install docker-run-cli
6363
source $(activate-python-docker-run-shell-completion 2> /dev/null)
6464
```
6565

66+
> **Warning**
67+
> Outside of a virtual environment, *pip* may default to a user-site installation of executables to `~/.local/bin`, which may not be present in your shell's `PATH`. If running `docker-run` errors with `docker-run: command not found`, add the directory to your path. [*(More information)*](https://packaging.python.org/en/latest/tutorials/installing-packages/#installing-to-the-user-site)
68+
> ```bash
69+
> echo "export PATH=$HOME/.local/bin:$PATH" >> ~/.bashrc
70+
> source ~/.bashrc
71+
> ```
72+
6673
6774
## Usage
6875

docker-run/pyproject.toml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
44

55
[project]
66
name = "docker-run-cli"
7-
version = "0.9.1"
7+
version = "0.9.2"
88
description = "'docker run' and 'docker exec' with useful defaults"
99
license = {file = "LICENSE"}
1010
readme = "README.md"

docker-run/scripts/docker-run

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -11,19 +11,18 @@ if [[ $OS != "Darwin" ]]; then
1111
echo "User '${USER}' must be in 'docker' group to run containers."
1212
echo "User can be added via: sudo usermod -aG docker ${USER}"
1313
echo "Afterwards, the user may need to logout and login again."
14-
exit 1
1514
fi
1615
fi
1716

1817
# check operating system and architecture
1918
if ! { [[ $OS = "Linux" && $ARCH = "x86_64" ]] || [[ $OS = "Darwin" && $ARCH = "arm64" ]] || [[ $OS = "Linux" && $ARCH = "aarch64" ]]; }; then
20-
>&2 echo "This script does not support $OS with $ARCH architecture."
19+
>&2 echo "docker-run does not support $OS with $ARCH architecture."
2120
exit 1
2221
fi
2322

2423
# generate docker run/exec command
2524
CMD_FILE=$(mktemp)
26-
python -m docker_run "${@}" 2>&1 >$CMD_FILE
25+
python3 -m docker_run "${@}" 2>&1 >$CMD_FILE
2726
CMD=$(cat $CMD_FILE)
2827
rm $CMD_FILE
2928

docker-run/src/docker_run/__init__.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,2 +1,2 @@
11
__name__ = "docker-run"
2-
__version__ = "0.9.1"
2+
__version__ = "0.9.2"

0 commit comments

Comments
 (0)