Skip to content

Commit 9195b69

Browse files
author
ihsanbal
committed
header fix & updating deprecated functions
1 parent c55f998 commit 9195b69

File tree

5 files changed

+28
-25
lines changed

5 files changed

+28
-25
lines changed

app/src/main/java/ihsanbal/com/logginginterceptor/LogApplication.kt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,8 +9,8 @@ import ihsanbal.com.logginginterceptor.di.NetModule
99
* @author ihsan on 09/02/2017.
1010
*/
1111
class LogApplication : Application() {
12+
1213
var appComponent: NetComponent? = null
13-
private set
1414

1515
override fun onCreate() {
1616
super.onCreate()

app/src/main/java/ihsanbal/com/logginginterceptor/di/NetModule.kt

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,14 +16,14 @@ import okio.source
1616
import retrofit2.Retrofit
1717
import retrofit2.adapter.rxjava.RxJavaCallAdapterFactory
1818
import retrofit2.converter.gson.GsonConverterFactory
19-
import java.util.concurrent.Executors
2019
import javax.inject.Singleton
2120

2221
/**
2322
* @author ihsan on 09/02/2017.
2423
*/
2524
@Module
2625
class NetModule(private val mEndPoint: String, private val mAssetManager: AssetManager) {
26+
2727
@Provides
2828
@Singleton
2929
fun provideOkHttpClient(): OkHttpClient {
@@ -34,7 +34,7 @@ class NetModule(private val mEndPoint: String, private val mAssetManager: AssetM
3434
.log(INFO)
3535
.addHeader("version", BuildConfig.VERSION_NAME)
3636
.addQueryParam("query", "0")
37-
.enableAndroidStudioV3LogsHack(true)
37+
// .enableAndroidStudioV3LogsHack(true)
3838
// .logger(object : Logger {
3939
// override fun log(level: Int, tag: String?, msg: String?) {
4040
// Log.e("$tag - $level", "$msg")
@@ -46,7 +46,6 @@ class NetModule(private val mEndPoint: String, private val mAssetManager: AssetM
4646
return mAssetManager.open(String.format("mock/%s.json", segment)).source().buffer().readUtf8()
4747
}
4848
})
49-
.executor(Executors.newSingleThreadExecutor())
5049
.build())
5150
return client.build()
5251
}

build.gradle

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,14 +21,14 @@ buildscript {
2121
dependencies {
2222
//noinspection
2323
classpath "org.jetbrains.kotlin:kotlin-gradle-plugin:$kotlin_version"
24-
classpath 'com.android.tools.build:gradle:3.5.3'
24+
classpath 'com.android.tools.build:gradle:3.6.1'
2525
}
2626
}
2727

2828
project.ext {
2929
groupId = 'com.github.ihsanbal'
3030
artifactId = 'LoggingInterceptor'
31-
snapshot = '3.1.0-rc1'
31+
snapshot = '3.1.0-rc2'
3232
}
3333

3434
allprojects {
Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
1-
#Wed Feb 19 23:49:27 EST 2020
1+
#Sun Mar 01 21:51:28 EST 2020
22
distributionBase=GRADLE_USER_HOME
33
distributionPath=wrapper/dists
44
zipStoreBase=GRADLE_USER_HOME
55
zipStorePath=wrapper/dists
6-
distributionUrl=https\://services.gradle.org/distributions/gradle-5.4.1-all.zip
6+
distributionUrl=https\://services.gradle.org/distributions/gradle-5.6.4-all.zip

lib/src/main/java/com/ihsanbal/logging/LoggingInterceptor.kt

Lines changed: 21 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -23,12 +23,7 @@ class LoggingInterceptor private constructor(private val builder: Builder) : Int
2323
return chain.proceed(request)
2424
}
2525

26-
Printer.printJsonRequest(
27-
builder,
28-
request.body,
29-
request.url.toUrl().toString(),
30-
request.headers,
31-
request.method)
26+
printlnRequestLog(request)
3227

3328
val startNs = System.nanoTime()
3429
val response: Response
@@ -40,6 +35,11 @@ class LoggingInterceptor private constructor(private val builder: Builder) : Int
4035
}
4136
val receivedMs = TimeUnit.NANOSECONDS.toMillis(System.nanoTime() - startNs)
4237

38+
printlnResponseLog(receivedMs, response, request)
39+
return response
40+
}
41+
42+
private fun printlnResponseLog(receivedMs: Long, response: Response, request: Request) {
4343
Printer.printJsonResponse(
4444
builder,
4545
receivedMs,
@@ -50,16 +50,20 @@ class LoggingInterceptor private constructor(private val builder: Builder) : Int
5050
request.url.encodedPathSegments,
5151
response.message,
5252
request.url.toString())
53-
return response
53+
}
54+
55+
private fun printlnRequestLog(request: Request) {
56+
Printer.printJsonRequest(
57+
builder,
58+
request.body,
59+
request.url.toUrl().toString(),
60+
request.headers,
61+
request.method)
5462
}
5563

5664
private fun proceedResponse(chain: Interceptor.Chain, request: Request): Response {
5765
return if (builder.isMockEnabled && builder.listener != null) {
58-
try {
59-
TimeUnit.MILLISECONDS.sleep(builder.sleepMs)
60-
} catch (e: InterruptedException) {
61-
e.printStackTrace()
62-
}
66+
TimeUnit.MILLISECONDS.sleep(builder.sleepMs)
6367
Response.Builder()
6468
.body(builder.listener!!.getJsonResponse(request)?.toResponseBody("application/json".toMediaTypeOrNull()))
6569
.request(chain.request())
@@ -83,7 +87,7 @@ class LoggingInterceptor private constructor(private val builder: Builder) : Int
8387
httpUrlBuilder.addQueryParameter(key, builder.httpUrl[key])
8488
}
8589
}
86-
return request.newBuilder().url(httpUrlBuilder?.build()!!).build()
90+
return requestBuilder.url(httpUrlBuilder?.build()!!).build()
8791
}
8892

8993
@Suppress("unused")
@@ -101,8 +105,6 @@ class LoggingInterceptor private constructor(private val builder: Builder) : Int
101105
private set
102106
var logger: Logger? = null
103107
private set
104-
var executor: Executor? = null
105-
private set
106108
var isMockEnabled = false
107109
var sleepMs: Long = 0
108110
var listener: BufferListener? = null
@@ -213,9 +215,9 @@ class LoggingInterceptor private constructor(private val builder: Builder) : Int
213215
* @return Builder
214216
* @see Logger
215217
*/
218+
@Deprecated(message = "Create your own Logcat filter for best result", level = DeprecationLevel.ERROR)
216219
fun executor(executor: Executor?): Builder {
217-
this.executor = executor
218-
return this
220+
TODO("Deprecated")
219221
}
220222

221223
/**
@@ -240,6 +242,8 @@ class LoggingInterceptor private constructor(private val builder: Builder) : Int
240242
* @return Builder
241243
* @see Logger
242244
*/
245+
@Deprecated(message = "Android studio has resolved problem for latest versions",
246+
level = DeprecationLevel.WARNING)
243247
fun enableAndroidStudioV3LogsHack(useHack: Boolean): Builder {
244248
isLogHackEnable = useHack
245249
return this

0 commit comments

Comments
 (0)