Coverity CID 468130

matt335672 · matt335672 · commit ffe9ac9122ca · 2025-04-22T14:51:26.000+01:00
g_bitmask_to_str() can return &lt; 0 on error. This is not adequately
catered for.
diff --git a/libxrdp/xrdp_iso.c b/libxrdp/xrdp_iso.c
@@ -68,7 +68,7 @@ protocol_mask_to_str(int protocol, char *buff, int bufflen)
         /* String is empty */
         rlen = g_snprintf(buff, bufflen, "RDP");
     }
-    else if (rlen < bufflen)
+    else if (rlen > 0 && rlen < bufflen)
     {
         rlen += g_snprintf(buff + rlen, bufflen - rlen, "%cRDP", delim);
     }

Original file line number	Diff line number	Diff line change
`@@ -68,7 +68,7 @@ protocol_mask_to_str(int protocol, char *buff, int bufflen)`
`68`	`68`	`/* String is empty */`
`69`	`69`	`rlen = g_snprintf(buff, bufflen, "RDP");`
`70`	`70`	`}`
`71`		`- else if (rlen < bufflen)`
	`71`	`+ else if (rlen > 0 && rlen < bufflen)`
`72`	`72`	`{`
`73`	`73`	`rlen += g_snprintf(buff + rlen, bufflen - rlen, "%cRDP", delim);`
`74`	`74`	`}`