Address review comments

Author: matt335672

docs/man/xrdp.ini.5.in

@@ -30,11 +30,11 @@ examples can be found within xrdp.ini itself.
 
 .TP
 \fBvmconnect\fR=\fI[true|false]\fR
-(Hyper-V VMs only). Allows the user to skip some unnecessary security
-checks when a virtual machine running xrdp is hosted on Hyper-V,
-and the user connects to it via the vmms service on TCP port 2179.
-In this configuration, RDP security is handled by the vmms service, and
-security features which are not yet added to xrdp itself can be supported.
+(Hyper-V VMs only). Enables a wider support of security protocols when a
+virtual machine running xrdp is hosted on Hyper-V, and the user connects
+to it via the vmms service on TCP port 2179. In this configuration,
+RDP security is handled by the vmms service, and security features which
+are not yet added to xrdp itself can be supported.
 
 This parameter is required in environments which do not support 'classic'
 RDP encryption.

xrdp/xrdp.c

@@ -332,6 +332,9 @@ read_xrdp_ini_startup_params(struct xrdp_startup_params *startup_params)
 
             else if (g_strcasecmp(name, "use_vsock") == 0)
             {
+                LOG(LOG_LEVEL_WARNING,
+                    "Config parameter 'use_vsock' is obsolete. "
+                    "Use 'port=vsock://...' instead");
                 startup_params->use_vsock = g_text2bool(val);
             }
 

xrdp/xrdp.ini.in

@@ -22,11 +22,6 @@ fork=true
 ;   port=vsock://<cid>:<port>
 port=3389
 
-; 'port' above should be connected to with vsock instead of tcp
-; use this only with number alone in port above
-; prefer use vsock://<cid>:<port> above
-use_vsock=false
-
 ; if used inside a Hyper-V VM through vmconnect and bound on vsock,
 ; turn this on to enable wider security protocol support.
 #vmconnect=true