Replies: 2 comments 1 reply
-
Yes this is in the long term plan. I'd suggest looking at: #91, and #393. If you want to volunteer, let's get a good implementation plan together :). |
Beta Was this translation helpful? Give feedback.
1 reply
-
Update: we have started the branch |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
-
Hello everyone,
I’ve been reviewing the code and noticed that there are several similar assertion blocks throughout. I wonder if we might consider refactoring these into helper functions (for example, _assert_type) to reduce redundancy and improve overall readability.
I believe this change could help streamline codebase and adhere more closely to the DRY principle. I’d be happy to contribute a pull request with these modifications if the team feels this is a beneficial improvement.
for example updating materials class adding assert method would already make this cleaner.
Beta Was this translation helpful? Give feedback.
All reactions