Start from the end of file since the compilation can now lose track when renaming a symbol before another rename

Author: GrahamTheCoder

CodeConverter/Common/SymbolRenamer.cs

@@ -24,10 +24,10 @@ public static string GetName(ISymbol m) {
         return m.Name;
     }
 
-    public static async Task<Project> PerformRenamesAsync(Project project, IReadOnlyCollection<(ISymbol Original, string NewName)> symbolsWithNewNames)
+    public static async Task<Project> PerformRenamesAsync(Project project, IEnumerable<(ISymbol Original, string NewName)> symbolsWithNewNames)
     {
         var solution = project.Solution;
-        foreach (var (originalSymbol, newName) in symbolsWithNewNames) {
+        foreach (var (originalSymbol, newName) in symbolsWithNewNames.OrderByDescending(s => s.Original.DeclaringSyntaxReferences.Select(x => x.Span.End).Max())) {
             project = solution.GetProject(project.Id);
             var compilation = await project.GetCompilationAsync();
             ISymbol currentDeclaration = SymbolFinder.FindSimilarSymbols(originalSymbol, compilation).FirstOrDefault();

CodeConverter/VB/ClashingMemberRenamer.cs

@@ -37,7 +37,7 @@ public static IEnumerable<IEnumerable<ISymbol>> GetLocalSymbolSets(INamespaceOrT
     }
 
     private static IEnumerable<(ISymbol Original, string NewName)> GetUniqueNamesForSymbolSet(IEnumerable<ISymbol> symbols) {
-        var membersByCaseInsensitiveName = symbols.ToLookup(SymbolRenamer.GetName, m => m, StringComparer.OrdinalIgnoreCase);
+        var membersByCaseInsensitiveName = symbols.ToLookup(SymbolRenamer.GetName, StringComparer.OrdinalIgnoreCase);
         var names = new HashSet<string>(membersByCaseInsensitiveName.Select(ms => ms.Key),
             StringComparer.OrdinalIgnoreCase);
         var symbolsWithNewNames = membersByCaseInsensitiveName.Where(ms => ms.Count() > 1)

Tests/VB/MemberTests.cs

@@ -765,17 +765,14 @@ Private testField As Integer
 
     Public Property Test As Integer
         Get
-            Dim TEST = 0
-            Return testField + TEST
+            Dim lTEST = 0
+            Return testField + lTEST
         End Get
         Set(ByVal value As Integer)
             testField = value
         End Set
     End Property
-End Class
-
-1 target compilation errors:
-BC30290: Local variable cannot have the same name as the function containing it.");
+End Class");
     }
 
     [Fact]

Tests/VB/SpecialConversionTests.cs

@@ -588,7 +588,7 @@ Public Custom Event Test As EventHandler
         End AddHandler
         RemoveHandler(ByVal value As EventHandler)
             Dim lTeSt1 As Object = 5
-            Dim lTesT As Integer = CInt(o)
+            Dim lTesT = CInt(o)
             testField = [Delegate].Remove(testField, value)
         End RemoveHandler
         RaiseEvent(ByVal sender As Object, ByVal e As EventArgs)