Skip to content

Commit 528de80

Browse files
committed
Allow creating new Builders using BaseRecordBuilder
The current `BaseRecordBuilder` interface defines some abstract methods, without declaring their visibility. This means it is by default, they are `package-private`, and we can't create sub-classes extending the behaviour. One scenario where extanding from another package is ideal would be when extra headers are required to be sent to Kafka. This commit changes the modifier to be public so others could extend them.
1 parent 9cf3711 commit 528de80

File tree

3 files changed

+5
-5
lines changed

3 files changed

+5
-5
lines changed

src/main/java/com/ibm/eventstreams/connect/mqsource/builders/BaseRecordBuilder.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,7 +85,7 @@ else if (kh.equals(MQSourceConnector.CONFIG_VALUE_MQ_RECORD_BUILDER_KEY_HEADER_J
8585
*
8686
* @throws JMSException Message could not be converted
8787
*/
88-
SchemaAndValue getKey(JMSContext context, String topic, Message message) throws JMSException {
88+
public SchemaAndValue getKey(JMSContext context, String topic, Message message) throws JMSException {
8989
Schema keySchema = null;
9090
Object key = null;
9191
String keystr;
@@ -134,7 +134,7 @@ SchemaAndValue getKey(JMSContext context, String topic, Message message) throws
134134
*
135135
* @throws JMSException Message could not be converted
136136
*/
137-
abstract SchemaAndValue getValue(JMSContext context, String topic, boolean messageBodyJms, Message message) throws JMSException;
137+
public abstract SchemaAndValue getValue(JMSContext context, String topic, boolean messageBodyJms, Message message) throws JMSException;
138138

139139
/**
140140
* Convert a message into a Kafka Connect SourceRecord.

src/main/java/com/ibm/eventstreams/connect/mqsource/builders/DefaultRecordBuilder.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -55,7 +55,7 @@ public DefaultRecordBuilder() {
5555
*
5656
* @throws JMSException Message could not be converted
5757
*/
58-
@Override SchemaAndValue getValue(JMSContext context, String topic, boolean messageBodyJms, Message message) throws JMSException {
58+
@Override public SchemaAndValue getValue(JMSContext context, String topic, boolean messageBodyJms, Message message) throws JMSException {
5959
Schema valueSchema = null;
6060
Object value = null;
6161

src/main/java/com/ibm/eventstreams/connect/mqsource/builders/JsonRecordBuilder.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ public JsonRecordBuilder() {
6464
*
6565
* @throws JMSException Message could not be converted
6666
*/
67-
@Override SchemaAndValue getValue(JMSContext context, String topic, boolean messageBodyJms, Message message) throws JMSException {
67+
@Override public SchemaAndValue getValue(JMSContext context, String topic, boolean messageBodyJms, Message message) throws JMSException {
6868
byte[] payload;
6969

7070
if (message instanceof BytesMessage) {
@@ -81,4 +81,4 @@ else if (message instanceof TextMessage) {
8181

8282
return converter.toConnectData(topic, payload);
8383
}
84-
}
84+
}

0 commit comments

Comments
 (0)