changes based on review comments

rswalmart · rswalmart · commit 0e2eb7a1be0d · 2019-11-26T14:35:12.000-06:00
diff --git a/src/main/java/com/ibm/eventstreams/connect/mqsource/builders/BaseRecordBuilder.java b/src/main/java/com/ibm/eventstreams/connect/mqsource/builders/BaseRecordBuilder.java
@@ -78,13 +78,11 @@ else if (kh.equals(MQSourceConnector.CONFIG_VALUE_MQ_RECORD_BUILDER_KEY_HEADER_J
             }
         }
 
-		String str = props.get(MQSourceConnector.CONFIG_NAME_MQ_JMS_PROPERTY_COPY_TO_KAFKA_HEADER);
+        String str = props.get(MQSourceConnector.CONFIG_NAME_MQ_JMS_PROPERTY_COPY_TO_KAFKA_HEADER);
 
-        if (Optional.of(str).isPresent()) {
-            copyJmsPropertiesFlag = Boolean.parseBoolean(str);
-        }
+        copyJmsPropertiesFlag = Boolean.parseBoolean(Optional.ofNullable(str).orElse("false"));
 
-		jmsToKafkaHeaderConverter = new JmsToKafkaHeaderConverter();
+        jmsToKafkaHeaderConverter = new JmsToKafkaHeaderConverter();
 
 
 		log.trace("[{}]  Exit {}.configure", Thread.currentThread().getId(), this.getClass().getName());

Original file line number	Diff line number	Diff line change
`@@ -78,13 +78,11 @@ else if (kh.equals(MQSourceConnector.CONFIG_VALUE_MQ_RECORD_BUILDER_KEY_HEADER_J`
`78`	`78`	`}`
`79`	`79`	`}`
`80`	`80`
`81`		`- String str = props.get(MQSourceConnector.CONFIG_NAME_MQ_JMS_PROPERTY_COPY_TO_KAFKA_HEADER);`
	`81`	`+ String str = props.get(MQSourceConnector.CONFIG_NAME_MQ_JMS_PROPERTY_COPY_TO_KAFKA_HEADER);`
`82`	`82`
`83`		`- if (Optional.of(str).isPresent()) {`
`84`		`- copyJmsPropertiesFlag = Boolean.parseBoolean(str);`
`85`		`- }`
	`83`	`+ copyJmsPropertiesFlag = Boolean.parseBoolean(Optional.ofNullable(str).orElse("false"));`
`86`	`84`
`87`		`- jmsToKafkaHeaderConverter = new JmsToKafkaHeaderConverter();`
	`85`	`+ jmsToKafkaHeaderConverter = new JmsToKafkaHeaderConverter();`
`88`	`86`
`89`	`87`
`90`	`88`	`log.trace("[{}] Exit {}.configure", Thread.currentThread().getId(), this.getClass().getName());`