Skip to content
This repository was archived by the owner on Dec 17, 2024. It is now read-only.

Commit b18b9f1

Browse files
committed
increase legibility of grid cell latency hover text
Fixes #875
1 parent b03e278 commit b18b9f1

File tree

2 files changed

+26
-3
lines changed

2 files changed

+26
-3
lines changed

app/plugins/modules/activation-visualizations/web/css/table.css

Lines changed: 25 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -325,7 +325,9 @@
325325
.activation-viz-timeline .grid-cell-content {
326326
border-radius: 1px / 2px;
327327
}
328-
.activation-viz-plugin .cell-container[color-by="duration"] .grid-cell:not(.grid-no-hover):not(.latency-2):hover,.repl-result .entity.activations:hover .activation-viz-plugin .grid .grid-cell {
328+
.activation-viz-plugin .cell-container[color-by="duration"] .grid-cell:not(.grid-no-hover).latency-0:hover,
329+
.activation-viz-plugin .cell-container[color-by="duration"] .grid-cell:not(.grid-no-hover).latency-5:hover,
330+
.repl-result .entity.activations:hover .activation-viz-plugin .grid .grid-cell {
329331
filter: saturate(2.25) brightness(1.25) !important;
330332
}
331333

@@ -373,6 +375,16 @@
373375
.activation-viz-plugin .cell-container[color-by="duration"] .grid-cell-occupied.latency-2 .grid-cell-content {
374376
background: hsla(201, 51%, 78%, 1); /* #d1e5f0 with lightness reduced from 88% to 78% */
375377
}
378+
.activation-viz-plugin .cell-container[color-by="duration"] .grid-cell-occupied .grid-cell-content span {
379+
/* increase contrast on hover; see shell issue #875 */
380+
font-weight: 400;
381+
}
382+
.activation-viz-plugin .cell-container[color-by="duration"] .grid-cell-occupied.latency-1:hover .grid-cell-content span,
383+
.activation-viz-plugin .cell-container[color-by="duration"] .grid-cell-occupied.latency-2:hover .grid-cell-content span,
384+
.activation-viz-plugin .cell-container[color-by="duration"] .grid-cell-occupied.latency-3:hover .grid-cell-content span {
385+
/* increase contrast on hover; see shell issue #875 */
386+
color: black;
387+
}
376388
.activation-viz-plugin .cell-container[color-by="duration"] .grid-cell-occupied.latency-3 .grid-cell-content {
377389
background: #fddbc7;
378390
}
@@ -474,7 +486,7 @@
474486
100% {-webkit-transform: scale(1.5, 1.5); opacity: 0.0;}
475487
}
476488
.activation-viz-plugin .grid .grid-cell:not(.grid-no-hover):hover {
477-
filter: saturate(4) !important;
489+
filter: saturate(4) brightness(0.9) !important;
478490
cursor: pointer;
479491
}
480492
.activation-viz-plugin .grid .grid-cell-content {
@@ -490,6 +502,17 @@
490502
}
491503

492504
/* innerLabel for cells; see cell.js: const innerLabel */
505+
.activation-viz-plugin .cell-container.zoom_-1 .grid-cell-content > span,
506+
.activation-viz-plugin .cell-container.zoom_-2 .grid-cell-content > span {
507+
/* the cells are too small for the inner latency label */
508+
opacity: 0
509+
}
510+
.activation-viz-plugin .cell-container.zoom_1 .grid-cell-content > span {
511+
font-size: 0.85vw;
512+
}
513+
.activation-viz-plugin .cell-container.zoom_2 .grid-cell-content > span {
514+
font-size: 1vw;
515+
}
493516
.activation-viz-plugin .grid-cell-content > span {
494517
font-size: 0.75vw;
495518
color: white;

app/templates/index.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -15,7 +15,7 @@
1515
<link rel="stylesheet" type="text/css" href="https://cdnjs.cloudflare.com/ajax/libs/balloon-css/0.5.0/balloon.min.css">
1616
<script src="../content/js/events.js"></script>
1717
<script src="../content/js/ui.js"></script>
18-
<script defer src="https://use.fontawesome.com/releases/v5.0.6/js/all.js"></script>
18+
<script defer src="https://use.fontawesome.com/releases/v5.0.9/js/all.js" integrity="sha384-8iPTk2s/jMVj81dnzb/iFR2sdA7u06vHJyyLlAd4snFpCl/SnyUjRrbdJsw1pGIl" crossorigin="anonymous"></script>
1919
</head>
2020

2121
<body onload="__shell_bootstrap()" class='still-loading'><div class="page">

0 commit comments

Comments
 (0)