Skip to content
This repository was archived by the owner on Dec 17, 2024. It is now read-only.

Commit 8fd96f7

Browse files
committed
disable timeline view for now
Fixes #794
1 parent 0a36892 commit 8fd96f7

File tree

7 files changed

+18
-9
lines changed

7 files changed

+18
-9
lines changed

app/content/css/ui.css

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1513,12 +1513,12 @@ break {
15131513
}
15141514
.list-paginator .list-paginator-left-buttons {
15151515
flex: 1;
1516+
font-size: 1rem;
15161517
font-variant: small-caps;
15171518
letter-spacing: 1px;
15181519
}
15191520
.list-paginator .list-paginator-left-buttons > span {
15201521
/* a list paginator left button */
1521-
opacity: 0.6;
15221522
transition: all 150ms ease-in-out;
15231523
}
15241524
.list-paginator .list-paginator-left-buttons > span:hover {

app/content/js/views/list/activations.js

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -396,7 +396,9 @@ const _render = ({entity, activationIds, container, noCrop=false, noPip=false, s
396396
leftButtons.classList.add('list-paginator-left-buttons')
397397

398398
// show summary buttons
399-
const buttons = [ 'summary', 'timeline', 'grid' ]
399+
const buttons = [ 'summary',
400+
// 'timeline', // disabled for now shell issue #794
401+
'grid' ]
400402
buttons.forEach(buttonText => {
401403
const command = buttonText, // it so happens...
402404
button = document.createElement('span')

app/plugins/modules/activation-visualizations/lib/modes.js

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,10 @@ const mode = mode => options => ({
3535
*/
3636
const modes = [
3737
mode('summary'),
38-
mode('timeline'),
38+
// mode('timeline'), // disabled for now shell issue #794
3939
mode('grid')
4040
]
41+
exports.modes = modes
4142

4243
/**
4344
* Return a view mode model, crafted for the given default mode, and

app/plugins/modules/activation-visualizations/lib/timeline-histogram.js

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -342,6 +342,9 @@ const _drawTimeline = ({options, content, timelineData}) => () => {
342342
*
343343
*/
344344
module.exports = (commandTree, prequire) => {
345+
// disabled for now shell issue #794
346+
return
347+
345348
const wsk = prequire('/ui/commands/openwhisk-core'),
346349
mkCmd = (cmd, extraOptions) => visualize(wsk, commandTree, cmd, viewName, drawTimeline, extraOptions),
347350
timelineIt = mkCmd('timeline'),

tests/tests/passes/04/z-activation-list-drilldowns.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -62,8 +62,9 @@ describe('List activations, then drill down to summary views', function() {
6262
drilldownWith('summary')
6363
closeSidecar()
6464

65-
drilldownWith('timeline')
66-
closeSidecar()
65+
// timeline disabled shell issue #794
66+
//drilldownWith('timeline')
67+
//closeSidecar()
6768

6869
drilldownWith('grid')
6970
closeSidecar()

tests/tests/passes/05/activation-grid-view.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -161,8 +161,9 @@ describe('Activation grid visualization', function() {
161161
const switcheroo = () => {
162162
switchTo('summary')
163163
switchTo('grid')
164-
switchTo('timeline')
165-
switchTo('grid')
164+
switchTo('summary')
165+
//switchTo('timeline')
166+
//switchTo('grid')
166167
}
167168

168169
switcheroo()

tests/tests/passes/05/activation-timeline-view.js

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -30,8 +30,9 @@ describe('Activation timeline visualization', function() {
3030

3131
it('should have an active repl', () => cli.waitForRepl(this.app))
3232

33-
const icon = `${ui.selectors.SIDECAR} .sidecar-header-icon-wrapper .sidecar-header-icon`
33+
// disabled for now shell issue #794
34+
/*const icon = `${ui.selectors.SIDECAR} .sidecar-header-icon-wrapper .sidecar-header-icon`
3435
it('should open timeline', () => cli.do('timeline', this.app)
3536
.then(() => this.app.client.waitForText(icon, 'timeline'))
36-
.catch(common.oops(this)))
37+
.catch(common.oops(this)))*/
3738
})

0 commit comments

Comments
 (0)